mirror of
https://github.com/terribleplan/next.js.git
synced 2024-01-19 02:48:18 +00:00
f8dfe026ec
* show warning if there is a title in _document.js Head
* dont loop through children in production
* only 1 loop through this.props.children 💪
* also raise warning in test env
* check for null childs
44 lines
1,010 B
Markdown
44 lines
1,010 B
Markdown
# `<title>` should not be used in _document.js's `<Head>`
|
|
|
|
#### Why This Error Occurred
|
|
|
|
Adding `<title>` in `pages/_document.js` will lead to unexpected results with `next/head` since `_document.js` is only rendered on the initial pre-render.
|
|
|
|
#### Possible Ways to Fix It
|
|
|
|
Set `<title>` in `pages/_app.js` instead :
|
|
|
|
```js
|
|
// pages/_app.js
|
|
import App, {Container} from 'next/app'
|
|
import Head from 'next/head'
|
|
import React from 'react'
|
|
|
|
export default class MyApp extends App {
|
|
static async getInitialProps ({ Component, router, ctx }) {
|
|
let pageProps = {}
|
|
|
|
if (Component.getInitialProps) {
|
|
pageProps = await Component.getInitialProps(ctx)
|
|
}
|
|
|
|
return {pageProps}
|
|
}
|
|
|
|
render () {
|
|
const {Component, pageProps} = this.props
|
|
return <Container>
|
|
<Head>
|
|
<title>My new cool app</title>
|
|
</Head>
|
|
<Component {...pageProps} />
|
|
</Container>
|
|
}
|
|
}
|
|
```
|
|
|
|
|
|
### Useful Links
|
|
|
|
- [The issue this was reported in: #4596](https://github.com/zeit/next.js/issues/4596)
|