mirror of
https://github.com/docker-mailserver/docker-mailserver.git
synced 2024-01-19 02:48:50 +00:00
a9d6e329cd
This was missed during original review. On a linux host, processes running within a container have been visible via commands like `pgrep`. This is does not appear to be the case with WSL2 + Docker Desktop (Windows), resulting in test failure. The command should have been run from within the container regardless.
205 lines
7.3 KiB
Bash
205 lines
7.3 KiB
Bash
load "${REPOSITORY_ROOT}/test/helper/common"
|
|
load "${REPOSITORY_ROOT}/test/helper/setup"
|
|
|
|
BATS_TEST_NAME_PREFIX='[Process Management] '
|
|
CONTAINER1_NAME='dms-test_process-check-restart_disabled'
|
|
CONTAINER2_NAME='dms-test_process-check-restart_enabled'
|
|
CONTAINER3_NAME='dms-test_process-check-restart_clamav'
|
|
|
|
function teardown() { _default_teardown ; }
|
|
|
|
# Process matching notes:
|
|
# opendkim (/usr/sbin/opendkim) - x2 of the same process are found running (1 is the parent)
|
|
# opendmarc (/usr/sbin/opendmarc)
|
|
# master (/usr/lib/postfix/sbin/master) - Postfix main process (Can take a few seconds running to be ready)
|
|
# NOTE: pgrep or pkill used with `--full` would also match `/usr/sbin/amavisd-new (master)`
|
|
#
|
|
# amavi (/usr/sbin/amavi) - Matches three processes, the main process is `/usr/sbin/amavisd-new (master)`
|
|
# NOTE: `amavisd-new` can only be matched with `--full`, regardless pkill would return `/usr/sbin/amavi`
|
|
#
|
|
# clamd (/usr/sbin/clamd)
|
|
# dovecot (/usr/sbin/dovecot)
|
|
# fetchmail (/usr/bin/fetchmail)
|
|
# fail2ban-server (/usr/bin/python3 /usr/bin/fail2ban-server) - Started by fail2ban-wrapper.sh
|
|
# postgrey (postgrey) - NOTE: This process lacks path information to match with `--full` in pgrep / pkill
|
|
# postsrsd (/usr/sbin/postsrsd) - NOTE: Also matches the wrapper: `/bin/bash /usr/local/bin/postsrsd-wrapper.sh`
|
|
# saslauthd (/usr/sbin/saslauthd) - x5 of the same process are found running (1 is a parent of 4)
|
|
|
|
# Delays:
|
|
# (An old process may still be running: `pkill -e opendkim && sleep 3 && pgrep -a --older 5 opendkim`)
|
|
# dovecot + fail2ban, take approx 1 sec to kill properly
|
|
# opendkim + opendmarc can take up to 6 sec to kill properly
|
|
# clamd + postsrsd sometimes take 1-3 sec to restart after old process is killed.
|
|
# postfix + fail2ban (due to Wrapper scripts) can delay a restart by up to 5 seconds from usage of sleep.
|
|
|
|
# These processes should always be running:
|
|
CORE_PROCESS_LIST=(
|
|
master
|
|
)
|
|
|
|
# These processes can be toggled via ENV:
|
|
# NOTE: clamd handled in separate test case
|
|
ENV_PROCESS_LIST=(
|
|
amavi
|
|
dovecot
|
|
fail2ban-server
|
|
fetchmail
|
|
opendkim
|
|
opendmarc
|
|
postgrey
|
|
postsrsd
|
|
saslauthd
|
|
)
|
|
|
|
@test "(disabled ENV) should only run expected processes" {
|
|
export CONTAINER_NAME=${CONTAINER1_NAME}
|
|
local CONTAINER_ARGS_ENV_CUSTOM=(
|
|
--env ENABLE_AMAVIS=0
|
|
--env ENABLE_CLAMAV=0
|
|
--env ENABLE_FAIL2BAN=0
|
|
--env ENABLE_FETCHMAIL=0
|
|
--env ENABLE_OPENDKIM=0
|
|
--env ENABLE_OPENDMARC=0
|
|
--env ENABLE_POSTGREY=0
|
|
--env ENABLE_SASLAUTHD=0
|
|
--env ENABLE_SRS=0
|
|
# Disable Dovecot:
|
|
--env SMTP_ONLY=1
|
|
)
|
|
_init_with_defaults
|
|
_common_container_setup 'CONTAINER_ARGS_ENV_CUSTOM'
|
|
|
|
# Required for Postfix (when launched by wrapper script which is slow to start)
|
|
_wait_for_smtp_port_in_container
|
|
|
|
for PROCESS in "${CORE_PROCESS_LIST[@]}"; do
|
|
run _check_if_process_is_running "${PROCESS}"
|
|
assert_success
|
|
assert_output --partial "${PROCESS}"
|
|
refute_output --partial "is not running"
|
|
done
|
|
|
|
for PROCESS in "${ENV_PROCESS_LIST[@]}" clamd; do
|
|
run _check_if_process_is_running "${PROCESS}"
|
|
assert_failure
|
|
assert_output --partial "'${PROCESS}' is not running"
|
|
done
|
|
}
|
|
|
|
# Average time: 23 seconds (29 with wrapper scripts)
|
|
@test "(enabled ENV) should restart processes when killed" {
|
|
export CONTAINER_NAME=${CONTAINER2_NAME}
|
|
local CONTAINER_ARGS_ENV_CUSTOM=(
|
|
--env ENABLE_AMAVIS=1
|
|
--env ENABLE_FAIL2BAN=1
|
|
--env ENABLE_FETCHMAIL=1
|
|
--env ENABLE_OPENDKIM=1
|
|
--env ENABLE_OPENDMARC=1
|
|
--env FETCHMAIL_PARALLEL=1
|
|
--env ENABLE_POSTGREY=1
|
|
--env ENABLE_SASLAUTHD=1
|
|
--env ENABLE_SRS=1
|
|
--env SMTP_ONLY=0
|
|
# Required workaround for some environments when using ENABLE_SRS=1:
|
|
# PR 2730: https://github.com/docker-mailserver/docker-mailserver/commit/672e9cf19a3bb1da309e8cea6ee728e58f905366
|
|
--ulimit "nofile=$(ulimit -Sn):$(ulimit -Hn)"
|
|
)
|
|
_init_with_defaults
|
|
mv "${TEST_TMP_CONFIG}/fetchmail/fetchmail.cf" "${TEST_TMP_CONFIG}/fetchmail.cf"
|
|
# Average time: 6 seconds
|
|
_common_container_setup 'CONTAINER_ARGS_ENV_CUSTOM'
|
|
|
|
local ENABLED_PROCESS_LIST=(
|
|
"${CORE_PROCESS_LIST[@]}"
|
|
"${ENV_PROCESS_LIST[@]}"
|
|
)
|
|
|
|
for PROCESS in "${ENABLED_PROCESS_LIST[@]}"; do
|
|
_should_restart_when_killed "${PROCESS}"
|
|
done
|
|
|
|
# By this point the fetchmail processes have been verified to exist and restart,
|
|
# For FETCHMAIL_PARALLEL=1 coverage, match full commandline for COUNTER values:
|
|
_run_in_container pgrep --full 'fetchmail-1.rc'
|
|
assert_success
|
|
_run_in_container pgrep --full 'fetchmail-2.rc'
|
|
assert_success
|
|
|
|
_should_stop_cleanly
|
|
}
|
|
|
|
# Split into separate test case for the benefit of minimizing CPU + RAM overhead of clamd.
|
|
# NOTE: Does not reduce test time of previous test case. Adds 10 seconds to test time.
|
|
@test "(enabled ENV) should restart clamd when killed" {
|
|
export CONTAINER_NAME=${CONTAINER3_NAME}
|
|
local CONTAINER_ARGS_ENV_CUSTOM=(
|
|
--env ENABLE_CLAMAV=1
|
|
)
|
|
_init_with_defaults
|
|
_common_container_setup 'CONTAINER_ARGS_ENV_CUSTOM'
|
|
|
|
_should_restart_when_killed 'clamd'
|
|
_should_stop_cleanly
|
|
}
|
|
|
|
function _should_restart_when_killed() {
|
|
local PROCESS=${1}
|
|
local MIN_PROCESS_AGE=4
|
|
|
|
# Wait until process has been running for at least MIN_PROCESS_AGE:
|
|
# (this allows us to more confidently check the process was restarted)
|
|
_run_until_success_or_timeout 30 _check_if_process_is_running "${PROCESS}" "${MIN_PROCESS_AGE}"
|
|
# NOTE: refute_output doesn't have output to compare to when a run failure is due to a timeout
|
|
assert_success
|
|
assert_output --partial "${PROCESS}"
|
|
|
|
# Should kill the process successfully:
|
|
# (which should then get restarted by supervisord)
|
|
_run_in_container pkill --echo "${PROCESS}"
|
|
assert_output --partial "${PROCESS}"
|
|
assert_success
|
|
|
|
# Wait until original process is not running:
|
|
# (Ignore restarted process by filtering with MIN_PROCESS_AGE, --fatal-test with `false` stops polling on error):
|
|
run _repeat_until_success_or_timeout --fatal-test "_check_if_process_is_running ${PROCESS} ${MIN_PROCESS_AGE}" 30 false
|
|
assert_output --partial "'${PROCESS}' is not running"
|
|
assert_failure
|
|
|
|
# Should be running:
|
|
# (poll as some processes a slower to restart, such as those run by wrapper scripts adding delay via sleep)
|
|
_run_until_success_or_timeout 30 _check_if_process_is_running "${PROCESS}"
|
|
assert_success
|
|
assert_output --partial "${PROCESS}"
|
|
}
|
|
|
|
# NOTE: CONTAINER_NAME is implicit; it should have be set prior to calling.
|
|
function _check_if_process_is_running() {
|
|
local PROCESS=${1}
|
|
local MIN_SECS_RUNNING
|
|
[[ -n ${2:-} ]] && MIN_SECS_RUNNING=('--older' "${2}")
|
|
|
|
local IS_RUNNING=$(docker exec "${CONTAINER_NAME}" pgrep --list-full "${MIN_SECS_RUNNING[@]}" "${PROCESS}")
|
|
|
|
# When no matches are found, nothing is returned. Provide something we can assert on (helpful for debugging):
|
|
if [[ ! ${IS_RUNNING} =~ ${PROCESS} ]]; then
|
|
echo "'${PROCESS}' is not running"
|
|
return 1
|
|
fi
|
|
|
|
# Original output (if any) for assertions
|
|
echo "${IS_RUNNING}"
|
|
}
|
|
|
|
# The process manager (supervisord) should perform a graceful shutdown:
|
|
# NOTE: Time limit should never be below these configured values:
|
|
# - supervisor-app.conf:stopwaitsecs
|
|
# - compose.yaml:stop_grace_period
|
|
function _should_stop_cleanly() {
|
|
run docker stop -t 60 "${CONTAINER_NAME}"
|
|
assert_success
|
|
|
|
# Running `docker rm -f` too soon after `docker stop` can result in failure during teardown with:
|
|
# "Error response from daemon: removal of container "${CONTAINER_NAME}" is already in progress"
|
|
sleep 1
|
|
}
|