mirror of
https://github.com/terribleplan/next.js.git
synced 2024-01-19 02:48:18 +00:00
8c6a4ebb1d
This fixes the generated page chunk created by the webpack `pages-plugin` which adds a new line in the beginning of the template, when using `output.libraryTarget` set to be [`umd`](https://webpack.js.org/configuration/output/#module-definition-systems) it returns the module. Consider the following example, which is the output with the previous implementation: ```js (function webpackUniversalModuleDefinition(root, factory) { if(typeof exports === 'object' && typeof module === 'object') module.exports = factory(); else if(typeof define === 'function' && define.amd) define([], factory); else if(typeof exports === 'object') exports["MyLibrary"] = factory(); else root["MyLibrary"] = factory(); })(typeof self !== 'undefined' ? self : this, function() { return __NEXT_REGISTER_PAGE(...) }); ``` `__NEXT_REGISTER_PAGE()` won't be executed since a `return` statement followed by a new line is the same as having a semicolon inserted right after the `return`. By removing the new line in the beginning of the source concatenation (which I suppose was added for stylistic reasons) this works as expected. |
||
|---|---|---|
| .. | ||
| build-manifest-plugin.js | ||
| dynamic-chunks-plugin.js | ||
| nextjs-ssr-import.js | ||
| pages-manifest-plugin.js | ||
| pages-plugin.js | ||
| unlink-file-plugin.js | ||