1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
next.js/test/integration
Kyle Holmberg 72e7929242 Change page export validity check on client and server in development (#5857)
Resolves #4055 

Credit: https://github.com/zeit/next.js/pull/5095

I didn't use the ignore webpack plugin from the original PR and tested bundle size with https://github.com/zeit/next.js/pull/5339 - seems to be safe on that front.

Was able to get tests to pass locally, unsure of what goes wrong in CI 🤷‍♂️ 

**Questions**
1) The initial PR didn't include changes to `next-server/lib/router` in `getRouteInfo()`. Should the same changes be made within?

2) Should we add a test for rendering a component created via `forwardRef()`?

`component-with-forwardedRef`:
```javascript
export default React.forwardRef((props, ref) => <span {...props} forwardedRef={ref}>This is a component with a forwarded ref</span>);
```

some test:
```javascript
test('renders from forwardRef', async () => {
  const $ = await get$('/component-with-forwardedRef')
  const span = $('span')
  expect(span.text()).toMatch(/This is a component with a forwarded ref/)
})
```
2018-12-17 16:09:23 +01:00
..
app-aspath Fix linter (#5350) 2018-10-20 17:00:01 +02:00
app-document Fix #5674 Append crossOrigin on the client side too, add config option for crossOrigin (#5873) 2018-12-13 01:05:21 +01:00
babel Fix linter (#5350) 2018-10-20 17:00:01 +02:00
basic Change page export validity check on client and server in development (#5857) 2018-12-17 16:09:23 +01:00
cli add --node-args option (#5858) 2018-12-15 22:55:59 +01:00
config Temporarily disable sass test 2018-11-29 19:23:00 +01:00
custom-server Use correct default for query (#5851) 2018-12-10 23:40:26 +01:00
dist-dir Fix linter (#5350) 2018-10-20 17:00:01 +02:00
export fix: update correct path to use when exporting 404 page (#5470) 2018-11-03 01:19:41 +01:00
filesystempublicroutes use native http instead of micro (#5706) 2018-11-19 16:36:18 +01:00
lambdas Add tests for isomorphic-unfetch bundling issue (#5805) 2018-12-04 10:59:12 +01:00
ondemand Implement websockets based on-demand-entries ping (#4508) 2018-12-14 12:25:59 +01:00
page-extensions Fix linter (#5350) 2018-10-20 17:00:01 +02:00
production Make sure 404 is rendered (#5880) 2018-12-13 19:46:16 +01:00
production-config Add test for generateBuildId (#5816) 2018-12-04 16:42:25 +01:00
size-limit Upgrade React from 16.4.2 to 16.6.3 (#5861) 2018-12-11 22:10:55 +01:00
with-router Fix linter (#5350) 2018-10-20 17:00:01 +02:00