next.js/examples/custom-server-typescript/nodemon.json at 1b8f56556b03c426d40ddcde00d843f81cf03ac0 - terribleplan/next.js - Terrible Software

terribleplan/next.js

mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00

Emmanuel Letallieur 82bdd43285 Fix custom-server-typescript not typechecking (#3954 )

Hi

In the current version of the example __custom-server-typescript__, types are never checked.
For instance, change the following line :
```
const dev = process.env.NODE_ENV !== 'production'
```
by :
```
const dev: number = process.env.NODE_ENV !== 'production'
```
then run `npm run dev`. The application launches perfectly, no error is thrown.

In dev environnement, it is preferable to check types all the time, to get immediate feedback. This PR activates type checking. Only when using nodemon, so no impact on production.


Now the above code will (rightfully) refuse to compile : 
```
TSError: ⨯ Unable to compile TypeScript
server/index.ts (6,7): Type 'boolean' is not assignable to type 'number'
```

2018-09-04 17:35:34 +02:00

7 lines

132 B

JSON

Raw Blame History

 {
   "watch": ["server/**/*.ts"],
   "execMap": {
     "ts": "ts-node --typeCheck --compilerOptions '{\"module\":\"commonjs\"}'"
   }
 }