1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Commit graph

454 commits

Author SHA1 Message Date
Tim Neutkens e9242705a3
Default query to {}, same behaviour as next export (#4466) 2018-05-25 14:27:18 +02:00
João Granado 8c6a4ebb1d Fix generated page chunk when libraryTarget is umd (#4205)
This fixes the generated page chunk created by the webpack `pages-plugin` which adds a new line in the beginning of the template, when using `output.libraryTarget` set to be [`umd`](https://webpack.js.org/configuration/output/#module-definition-systems) it returns the module.

Consider the following example, which is the output with the previous implementation:

```js
(function webpackUniversalModuleDefinition(root, factory) {
  if(typeof exports === 'object' && typeof module === 'object')
    module.exports = factory();
  else if(typeof define === 'function' && define.amd)
    define([], factory);
  else if(typeof exports === 'object')
    exports["MyLibrary"] = factory();
  else
    root["MyLibrary"] = factory();
})(typeof self !== 'undefined' ? self : this, function() {
  return
    __NEXT_REGISTER_PAGE(...)
});
```

`__NEXT_REGISTER_PAGE()` won't be executed since a `return` statement followed by a new line is the same as having a semicolon inserted right after the `return`. By removing the new line in the beginning of the source concatenation (which I suppose was added for stylistic reasons) this works as expected.
2018-05-25 14:23:44 +02:00
Logan Smyth 2495316235 Use custom Babel loader to avoid using separate Babel copies for loader and loader options (#4417)
This resolves the

> .value is not a valid Plugin property

error showing up for people in https://github.com/zeit/next.js/issues/4227

cc @timneutkens
2018-05-23 20:26:57 +02:00
Tim Neutkens f620b8f455
Don’t use chunkhash in development (#4436)
* Don’t use chunkhash in development

* Add test for dynamic imports styling

* Remove pre-load of dynamic page

* Make sure the browser gets closed only once
2018-05-23 14:37:02 +02:00
Jon Espen Kvisler f2261050a0 Set cache-control public (again) (#4322)
* set cache-control public

* test for Cache-Control header

* set Cache-Control header for commons/main.js
2018-05-19 21:43:18 +02:00
Yuri bced1b1c25 Fixing ios10 issue with webpack-uglify plugin (#4385)
* fix: fixing issue with ios10 and webpack uglify es httebpack-plugin/issues/92

* chore: formatting

* chore: formatting
2018-05-16 14:07:10 +02:00
Tim Neutkens 44c7aa44c3 Make sure _document doesn’t reload the page when switching pages 2018-05-16 10:08:18 +02:00
Tim Neutkens 535bab167b
Fix double-reload / redirect when changing pages (#4388)
When changing a page `/_app` can be seen as “updated”,  but the router shouldn’t reload it, because there is an ongoing/going to be ongoing update.
2018-05-16 00:36:24 +02:00
Cédric Marcone d3c710b325 Fixes 'next export' when exportPathMap function depends on runtime config (#4339) 2018-05-11 14:52:39 +02:00
Drew Hays 4881cd346b Update Cache-Control for render errors (#4111)
When running some tests, I noticed that Akamai was still caching the
response for render errors for some reason.  Honestly, I would've
thought that `no-store, must-revalidate` would be enough to prevent
the CDN from caching it.

That being said, MDN's documentation on [Cache-Control] has a section
called ["Preventing Caching"] and recommends also using the `no-cache`
directive.

Given the definitions provided for `no-cache` and `no-store`, I can't
tell much of a difference between these two.  But I _do_ know that,
for whatever reason, Akamai seems to respect the `no-cache` value for
this header.

[Cache-Control]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control
["Preventing Caching"]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#Preventing_caching
2018-05-06 22:57:27 +02:00
Tim Neutkens eb25cf4cb5
Support Node 6 again. check if async/await is supported (#4283) 2018-05-06 18:39:29 +02:00
Tim Neutkens 3da0049424
Catch errors from update-check (#4276)
Makes sure that Next.js can be started in development mode while being offline.
2018-05-05 05:49:21 -07:00
Tim Neutkens 02bcfb21c8
Add export of homepage when exporting without exportPathMap (#4253) 2018-05-02 10:37:52 -07:00
Tim Neutkens 737f6cfce0
Set babelrc true (#4215) 2018-04-26 11:26:42 -07:00
Tim Neutkens 0f2c8f5eb1
Exclude _app.js since it’s not a normal page (#4201) 2018-04-23 13:27:53 -07:00
Tim Neutkens f373d25c0d
Replaced update checker (#4192)
* Use update-check

* Check for tty
2018-04-22 15:43:24 -07:00
Tim Neutkens 68626c5147 Improved stacktraces (minor) (#4156)
* Handle production errors correctly

* Improved source map support

* Make react-hot-loader hold state again

* Remove console.log

* Load modules on demand

* Catch errors in rewriteErrorTrace

* Update comment

* Update comment

* Remove source-map-support

* Load modules in next-dev

* Make sure error logged has sourcemaps too

* Add tests for production runtime errors

* Add tests for development runtime errors. Fix issue with client side errors in development

* Move functionality back to renderError now that error handling is consistent

* Rename to applySourcemaps
2018-04-18 21:48:06 +05:30
Tim Neutkens 05b7286454
Use object directly since webpack doesn’t parse the string (#4140) 2018-04-14 10:18:41 +02:00
Tim Neutkens eca8e8f64b
Expose app.js (#4129)
* Expose pages/_app.js

* Add tests for _app and _document

* Uncomment deprecation warnings

* Add documentation for _app, improve documentation of _document

* Update docs / test for _document

* Add _document to client compiler in development

* Add missing app.js to comment

* Only warn once

* Add url-deprecated error page

* Combine tests

* Yse same message for all methods of ‘props.url’

* Update docs around _app

* Update documentation

* Quotes

* Update table of contents
2018-04-12 10:33:22 +02:00
Tim Neutkens 15dde33794
Add build manifest (#4119)
* Add build manifest

* Split out css since they don’t have exact name

* Remove pages map

* Fix locations test

* Re-run tests

* Get consistent open ports

* Fix static tests

* Add comment about Cache-Control header
2018-04-12 09:47:42 +02:00
Tim Neutkens dac2f39a25 Add support for exportPathMap in development (#4094)
* Add support for exportPathMap in development

* Add comment about what it does
2018-04-05 07:18:11 +05:30
Tim Neutkens 2d8c19a450
Upgrade Babel 6 to Babel 7 (major) (#4050)
Upgrade Babel 6 to Babel 7 (major)
2018-04-03 09:34:07 +02:00
Tim Neutkens 9d4891f295
Check if matched before reading value (#4096) 2018-04-02 21:18:33 +02:00
Tim Neutkens c3318d8ef6
Make sure hot-self-accept-loader cleans up the route correctly (#4092) 2018-03-31 23:19:06 +02:00
Craig McNamara 7f335cb032 Allow BUILD_ID to be set using generateBuildId (minor) (#3873)
* Allow BUILD_ID to be set in the environment

This makes multi server deploys with Capistrano possible.

* next.config.js generateBuildId support

enable customising the build id via config

* Provide default for generateBuildId

* This is not used
2018-03-31 16:34:52 +02:00
Tim Neutkens a785f303f4
Match externals ending in .js not everything with .js (#4091)
Makes sure highlight.js/styles/dark.css doesn’t get caught by externals.
2018-03-31 16:08:16 +02:00
Tim Neutkens 0b9b902a89 Get pages before entry function (#4089) 2018-03-31 17:30:56 +05:30
Tim Teeling 9ec81c00fa Fix #3900 return 404 on asset hash mismatch in prod (#3941)
* Fix #3900 return 404 on asset hash mismatch in prod

* Make INVALID_BUILD_ID return 404
2018-03-31 09:01:46 +02:00
Samatar 56998a6193 Remove mz-fs and glob-promise (#4026)
* Remove mz and add promisify util

* Remove glob-promise and promisify glob

* Use access instead of exists

* Use promisify for access
2018-03-30 20:29:42 +05:30
Tim Neutkens e90f89633c
Add flow, pages-manifest.json, defaultPathMap for export (minor) (#4066)
* Initial implementation of next export without exportPathMap

* Shorter message

* Set up flow

* Create pages manifest

* Use pagesManifest for next export

* Fix tests

* Document defaultPathMap

* Replacing the path is no longer needed

* Use posix normalize for consistent behaviour

* Remove second instance of examples

* Add comment about what pages-manifest does

* Make windows path a route
2018-03-30 15:08:09 +02:00
Tim Neutkens ebf0c47c25
Upgrade standard.js (#4064)
* Upgrade standard.js

# Conflicts:
#	yarn.lock

* Upgrade babel-eslint
2018-03-27 20:11:03 +02:00
Tim Neutkens 14a16924c5 Make sourcemap paths relative in production 2018-03-23 17:10:23 +01:00
Tim Neutkens ac7a23d595
Make sure react and react-dom are bundled to main.js in development (#4039)
Signed-off-by: Tim Neutkens <timneutkens@me.com>
2018-03-21 12:16:44 +01:00
Tomáš Witek c73f7d6ace Unlink only pages bundle in dev env (#4015)
* Unlink only pages bundle in dev env

* Use IS_BUNDLED_PAGE regexp for unlink file plugin
2018-03-15 22:04:17 +05:30
Oscar Martinez eff27bdcfb Allow etags to be disabled with config option (#3915)
* Allow etags to be disabled with config option

- CR Change: Rename option to generateEtags
- CR Change: Add tests for etag generation
- CR Change: Refactor to use next.config.js
- Update documentation

* Use renderOpts instead of passing nextConfig
2018-03-13 14:18:59 +01:00
Tim Neutkens 7e9f4f9327
Only show 404 when the page does not exist (#3976)
* Only show 404 when the page does not exist

* Do async filesystem check
2018-03-09 17:14:30 +01:00
Tomas Roos 4757836a67 Expose manifest.js.map during development (#3975) 2018-03-09 12:23:21 +01:00
Tomas Roos 40d926d794 Expose main.js.map (#3969) 2018-03-08 11:49:25 +01:00
Tim Neutkens 521b722aa2 Enable conditionals and evaluate uglify 2018-03-08 09:52:40 +01:00
Tomas Roos 76582b8e43 Enable source maps in webpack chunking + bundling process (#3793)
* Removed combine-assets-plugin, since its very broken

* Bundle everything into app.js on production build

* Clean up

* Removed app.js from server routes

* Renamed app.js -> main.js and removed commons from loading

* Remove commons and react CommonChunks

* Removed the commons route

* Killing the entire build-stats hack for app.js

* Removed unused md5-file package
2018-03-06 10:45:29 +01:00
Tim Neutkens 0107051eaa
Set default for serverRuntimeConfig (#3938) 2018-03-05 14:00:29 +01:00
Tim Neutkens 802e879d33
Implement new next/config keys (#3909) 2018-02-27 17:50:14 +01:00
Tim Neutkens 1aade36f13
Exposing configuration to the server / client side (minor) (#3882)
* Add next/config

* Set config on server start / client render

* Add documentation for next/config

* Add next/config support for next export

* Fix test

* Use the correct name

* Set default to empty object on the client side

* Add config tests

* Rename config to runtimeConfig
2018-02-26 12:03:27 +01:00
Arunoda Susiripala 77c8677e58
Fix SSR error handling in the global scope (#3877)
* Fix SSR error handling.

* Remove unwanted console.logs

* Fix a typo.

* Fix current tests.

* Add a new test case for this case.

* Error should only be logged if it is not a 404
2018-02-24 18:49:08 +05:30
Tim Neutkens 5017f91d23 Allow next.config.js to export a function (#3867)
* Allow next.config.js to export a function

* Expose phases to the configuration function

* Use same value as variable name

* Add next/constants

* Add documentation for config function / phases

* Add constants.js to npm bundle
2018-02-23 19:12:06 +05:30
Arunoda Susiripala a32b22bb2d
Remove special error script handling (#3849)
* Remove special error script handling.
As a result of that, we can't detect 500 errors and buildIdMismatch via client side.

* Fix failing test cases.

* Refactor the code base.

* Remove Router.onAppUpdated
2018-02-21 23:11:25 +05:30
Olivier Tassinari 832425e67e fix w3c warnings (#3572) 2018-02-21 18:45:51 +05:30
Arunoda Susiripala 9cfea69ab1 [SSR] Use relative paths in dynamic import output code (#3844)
* [SSR] Use relative paths in dynamic import output code
Now we use relative paths in the output code of dynamic import
in the server side.

* Remove unwanted constructor.
2018-02-19 11:49:41 +01:00
Tim Neutkens c204cdd91e Read compiler.context instead of this.context (#3839) 2018-02-19 13:19:59 +05:30
Tim Neutkens 7e756ee5d9
Expose totalPages to the webpack decorator (#3824) 2018-02-17 12:37:33 +01:00