next.js

terribleplan/next.js

Fork 0

mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00

Commit graph

Author	SHA1	Message	Date
Már Örlygsson	766d7d5fe4	Run initializeStore() only once per route on server (#5644 ) On the server `props.initialMobxState` received by the `constructor` is a fully functioning mobx store that was instantiated by `getInitialProps()` only a few ticks earlier. Thus, creating a new instance is unneccessary. In the browser, however, `props.initialMobxState` is a hydrated plain object and thus the store needs to be initialized.	2018-11-20 15:53:28 +01:00
Már Örlygsson	420f74c867	examples/with-mobx : Fix and simplify (#5537 ) I spent far too much time fiddling with this example project before realizing it contained a bug in the store initialization logic and it was a bit more complex than it needed to be. * The custom server was not needed * The store-initialization did effectively the same thing twice for no reason * And wrapping MyApp component in a HOC was wholly unnecessary indirection My changes are split into four discrete commits for clarity.	2018-11-06 10:18:26 +01:00
Junyoung Choi (Sai)	a25359bf3f	Improve with-mobx example (#4705 ) in flavor of https://github.com/zeit/next.js/pull/4377	2018-06-30 22:29:24 +02:00

Author

SHA1

Message

Date

Már Örlygsson

766d7d5fe4

Run initializeStore() only once per route on server (#5644 )

On the server `props.initialMobxState` received by the `constructor` is a fully functioning mobx store that was instantiated by `getInitialProps()` only a few ticks earlier.
Thus, creating a new instance is unneccessary.

In the browser, however, `props.initialMobxState` is a hydrated plain object and thus the store needs to be initialized.

2018-11-20 15:53:28 +01:00

Már Örlygsson

420f74c867

examples/with-mobx : Fix and simplify (#5537 )

I spent far too much time fiddling with this example project before realizing it contained a bug in the store initialization logic and it was a bit more complex than it needed to be.

* The custom server was not needed
* The store-initialization did effectively the same thing twice for no reason
* And wrapping MyApp component in a HOC was wholly unnecessary indirection

My changes are split into four discrete commits for clarity.

2018-11-06 10:18:26 +01:00

Junyoung Choi (Sai)

a25359bf3f

Improve with-mobx example (#4705 )

in flavor of https://github.com/zeit/next.js/pull/4377

2018-06-30 22:29:24 +02:00

3 commits