terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity
2855 commits 5 branches 325 tags 42 MiB
Commit graph

5 commits

Author SHA1 Message Date
Alexander Nanberg ff5cf6d4de Migrate next/head to use React.createContext (#6038) 
Continuation of #5945
 2019-01-14 01:59:26 +01:00
Jayden Seric 49fea51f34 Fix Head.propTypes (#6020) 
This PR fixes the buggy `Head.propTypes` here:

https://github.com/zeit/next.js/blob/v8.0.0-canary.3/packages/next-server/lib/head.js#L107

Currently, `Head.propTypes` allows one child node like this:

```jsx
import Head from 'next/head'

// …

<Head>
  <title>Title</title>
</Head>
```

But more than one child node mistakenly causes a prop type error like this:

```jsx
<Head>
  <title>Title</title>
  <meta name="description" content="Description." />
</Head>
```

```
Warning: Failed prop type: Invalid prop `children` supplied to `Head`.
```
 2019-01-10 12:53:43 +01:00
Tim Neutkens 9890e06907
Dedupe only items with unique key (#5800) 
Fixes #3705
Fixes #4656

- No longer automatically dedupe certain tags. Only the ones we know are *never* going to be duplicate like charSet, title etc.
- Fix `key=""` behavior, making sure that if a unique key is provided tags are deduped based on that.

For example:

```jsx
<meta property='fb:pages' content='one'>
<meta property='fb:pages' content='two'>
```

Would currently cause

```jsx
<meta property='fb:pages' content='two'>
```

### After this change:

```jsx
<meta property='fb:pages' content='one'>
<meta property='fb:pages' content='two'>
```

Then if you use next/head multiple times / want to be able to override:

```jsx
<meta property='fb:pages' content='one' key="not-unique-key">
<meta property='fb:pages' content='two' key="not-unique-key">
```

Would cause:

```jsx
<meta property='fb:pages' content='two'>
```

As `key` gets deduped correctly after this PR, similar to how React itself works.
 2018-12-03 17:28:42 +01:00
Patrick Smith 98568046a3 Add PropType validation for next/head children (#5504) 
Give `Head` a more detailed error messages in dev mode by validating the children prop's PropTypes.
 2018-10-28 23:04:35 +01:00
Tim Neutkens 82d56e063a
next-server (#5357) 2018-10-02 00:55:31 +02:00
Renamed from packages/next/lib/head.js (Browse further)