next.js

terribleplan/next.js

Fork 0

mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00

Commit graph

Author	SHA1	Message	Date
Tim Neutkens	b7e256ba01	Make onClick Link tests more consistent (#4954 )	2018-08-15 12:42:56 -07:00
Michał Miszczyszyn	669225263d	Allow onClick on next/link component's child (#4474 ) Allow `onClick` on `next/link` child. This should not be a breaking change, but it's a very useful feature. Real-life use cases include: analytics or closing menu on navigation, and other. - [x] allow optional `onClick` on `next/link` component's child - [x] call original `child.props.onClick(e)` before `this.linkClicked(e)` - [x] add integration tests - [x] cancel the navigation if `e.defaultPrevented === true` Fixes #1490	2018-05-27 20:47:02 +02:00

Author

SHA1

Message

Date

Tim Neutkens

b7e256ba01

Make onClick Link tests more consistent (#4954 )

2018-08-15 12:42:56 -07:00

Michał Miszczyszyn

669225263d

Allow onClick on next/link component's child (#4474 )

Allow `onClick` on `next/link` child. This should not be a breaking change, but it's a very useful feature. Real-life use cases include: analytics or closing menu on navigation, and other.

- [x] allow optional `onClick` on `next/link` component's child
- [x] call original `child.props.onClick(e)` before `this.linkClicked(e)`
- [x] add integration tests
- [x] cancel the navigation if `e.defaultPrevented === true`

Fixes #1490

2018-05-27 20:47:02 +02:00

2 commits