terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

with-apollo: Improve lib/withData (#3973)

Browse source 
* pass down getInitialProps ctx to ComposedComponent
* pass apollo client instance directly to getDataFromTree instead of through the ApolloProvider wrapper.
* Avoid redundant empty serverState initialization (It's always initialized)
This commit is contained in:
Shaleen Jain 2018-03-16 16:22:30 +05:30 committed by Tim Neutkens
parent c73f7d6ace
commit cd1d9e0c35
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
examples/with-apollo/lib/withData.js
View file

@ -20,11 +20,7 @@ export default ComposedComponent => {
static async getInitialProps(ctx) {
// Initial serverState with apollo (empty)
let serverState = {
apollo: {
data: {}
}
}
let serverState
// Evaluate the composed component's getInitialProps()
let composedInitialProps = {}
@ -38,15 +34,14 @@ export default ComposedComponent => {
try {
// Run all GraphQL queries
await getDataFromTree(
<ApolloProvider client={apollo}>
<ComposedComponent {...composedInitialProps} />
</ApolloProvider>,
<ComposedComponent ctx={ctx} {...composedInitialProps} />,
{
router: {
asPath: ctx.asPath,
pathname: ctx.pathname,
query: ctx.query
}
},
client: apollo
}
)
} catch (error) {