terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

dynamic imports fix for non-webpack environments. (#3414)

Browse source 
* Added condition to check whether method exists or not

* Conditional loop based on feature detection

* Added code comments as requested by the author
This commit is contained in:
PrudviGali 2017-12-07 19:50:38 -06:00 committed by Arunoda Susiripala
parent 5ce05c2d22
commit bd20deb9ba
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
server/build/babel/plugins/handle-import.js
View file

@ -7,9 +7,16 @@ import Crypto from 'crypto'
const TYPE_IMPORT = 'Import'
/*
Added "typeof require.resolveWeak !== 'function'" check instead of
"typeof window === 'undefined'" to support dynamic impports in non-webpack environments.
"require.resolveWeak" and "require.ensure" are webpack specific methods.
They would fail in Node/CommonJS environments.
*/
const buildImport = (args) => (template(`
(
typeof window === 'undefined' ?
typeof require.resolveWeak !== 'function' ?
new (require('next/dynamic').SameLoopPromise)((resolve, reject) => {
eval('require.ensure = function (deps, callback) { callback(require) }')
require.ensure([], (require) => {