From bc185878e8afae7de6598b5b7538170756143ec1 Mon Sep 17 00:00:00 2001 From: Jay Phelps Date: Fri, 16 Feb 2018 02:01:00 -0800 Subject: [PATCH] change mergeMap -> map in redux-observable example (#3794) Using `mergeMap` with an inner Observable `of` is the same as using `map` by itself, so this is more idiomatic and clear. --- examples/with-redux-observable/redux/epics.js | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/examples/with-redux-observable/redux/epics.js b/examples/with-redux-observable/redux/epics.js index 3dd962af..f2444321 100644 --- a/examples/with-redux-observable/redux/epics.js +++ b/examples/with-redux-observable/redux/epics.js @@ -1,6 +1,6 @@ import { interval } from 'rxjs/observable/interval' import { of } from 'rxjs/observable/of' -import { takeUntil, mergeMap, catchError } from 'rxjs/operators' +import { takeUntil, mergeMap, catchError, map } from 'rxjs/operators' import { combineEpics, ofType } from 'redux-observable' import ajax from 'universal-rx-request' // because standard AjaxObservable only works in browser @@ -13,11 +13,9 @@ export const fetchUserEpic = (action$, store) => mergeMap(action => { return interval(3000).pipe( mergeMap(x => - of( - actions.fetchCharacter({ - isServer: store.getState().isServer - }) - ) + actions.fetchCharacter({ + isServer: store.getState().isServer + }) ), takeUntil(action$.ofType(types.STOP_FETCHING_CHARACTERS)) ) @@ -31,12 +29,10 @@ export const fetchCharacterEpic = (action$, store) => ajax({ url: `https://swapi.co/api/people/${store.getState().nextCharacterId}` }).pipe( - mergeMap(response => - of( - actions.fetchCharacterSuccess( - response.body, - store.getState().isServer - ) + map(response => + actions.fetchCharacterSuccess( + response.body, + store.getState().isServer ) ), catchError(error =>