terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

do not use window.history if inside iframe (#3437)

Browse source 
* do not use window.history if inside iframe

* Move security related test cases into a its own file.

* Removes the unused renderScript function

* Add a nerv example. (#3573)

* Add a nerv example.

* Fix for indentation/style

* Fix for name

* warn user about browser history if next.js used in iframe
This commit is contained in:
Henric Malmberg 2018-02-04 13:00:38 +01:00 committed by Tim Neutkens
parent 3bbfbfad5c
commit b8f189f2a5
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/router/router.js
View file

@ -4,7 +4,7 @@ import { parse, format } from 'url'
import EventEmitter from '../EventEmitter' import EventEmitter from '../EventEmitter'
import shallowEquals from '../shallow-equals' import shallowEquals from '../shallow-equals'
import PQueue from '../p-queue' import PQueue from '../p-queue'
import { loadGetInitialProps, getURL } from '../utils' import { loadGetInitialProps, getURL, warn, execOnce } from '../utils'
import { _notifyBuildIdMismatch, _rewriteUrlForNextExport } from './' import { _notifyBuildIdMismatch, _rewriteUrlForNextExport } from './'
export default class Router { export default class Router {
@ -185,7 +185,9 @@ export default class Router {
} }
changeState (method, url, as, options = {}) { changeState (method, url, as, options = {}) {
if (method !== 'pushState' || getURL() !== as) { if (window.frameElement) {
execOnce(warn)(`Warning: You're using Next.js inside an iFrame. Browser history is disabled.`)
} else if (method !== 'pushState' || getURL() !== as) {
window.history[method]({ url, as, options }, null, as) window.history[method]({ url, as, options }, null, as)
} }
} }