terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

Fix serve command (#3989)

Browse source 
* Fix serve command

From the Firebase docs, you must use --only in order to run the local function emulator.
See https://firebase.google.com/docs/functions/local-emulator

* Add production env for firebase serve

Doesn't work without this

* Update text as suggested by @jthegedus
This commit is contained in:
Jonathan James 2018-03-31 09:59:24 -04:00 committed by Tim Neutkens
parent bd50a7c74a
commit b39958e780
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
examples/with-firebase-hosting/README.md
View file

@ -43,13 +43,9 @@ npm run dev
#### Run Firebase locally for testing: #### Run Firebase locally for testing:
Unfortunately I have been unable to get any combination of
```bash
firebase serve --only functions,hosting
``` ```
npm run serve
to locally host the built Next.js app as expected. [This issue is where solutions are being explored](https://github.com/firebase/firebase-tools/issues/535) and they will be shared here and on the [Next.js repo's similar issue](https://github.com/zeit/next.js/issues/3167) when discovered. ```
#### Deploy it to the cloud with Firebase: #### Deploy it to the cloud with Firebase:

2
examples/with-firebase-hosting/package.json
View file

@ -4,7 +4,7 @@
"description": "Host Next.js SSR app on Firebase Cloud Functions with Firebase Hosting redirects.", "description": "Host Next.js SSR app on Firebase Cloud Functions with Firebase Hosting redirects.",
"scripts": { "scripts": {
"dev": "next src/app", "dev": "next src/app",
"serve": "echo \"for details see:\n\thttps://github.com/firebase/firebase-tools/issues/535 \n\thttps://github.com/zeit/next.js/issues/3167\";", "serve": "NODE_ENV=production firebase serve --only functions,hosting",
"deploy": "firebase deploy", "deploy": "firebase deploy",
"clean": "rimraf \"dist/functions\" && rimraf \"dist/public\"", "clean": "rimraf \"dist/functions\" && rimraf \"dist/public\"",
"build-public": "cpx \"src/public/**/*.*\" \"dist/public\" -C", "build-public": "cpx \"src/public/**/*.*\" \"dist/public\" -C",