terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

Warn if a specific page is not found in build manifest (#4986)

Browse source 
There's an edge case @timothyis is running into, this will show exactly what files are missing.

I currently can't reproduce, so this is a first step at providing better error messages
This commit is contained in:
Tim Neutkens 2018-08-20 13:01:21 +02:00 committed by GitHub
parent e4a94acd96
commit a9a3fc1fca
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
server/render.js
View file

@ -43,6 +43,18 @@ export function renderErrorToHTML (err, req, res, pathname, query, opts = {}) {
return doRender(req, res, pathname, query, { ...opts, err, page: '/_error' }) return doRender(req, res, pathname, query, { ...opts, err, page: '/_error' })
} }
function getPageFiles (buildManifest, page) {
const normalizedPage = normalizePagePath(page)
const files = buildManifest.pages[normalizedPage]
if (!files) {
console.warn(`Could not find files for ${normalizedPage} in .next/build-manifest.json`)
return []
}
return files
}
async function doRender (req, res, pathname, query, { async function doRender (req, res, pathname, query, {
err, err,
page, page,
@ -87,9 +99,9 @@ async function doRender (req, res, pathname, query, {
const devFiles = buildManifest.devFiles const devFiles = buildManifest.devFiles
const files = [ const files = [
...new Set([ ...new Set([
...buildManifest.pages[normalizePagePath(page)], ...getPageFiles(buildManifest, page),
...buildManifest.pages[normalizePagePath('/_app')], ...getPageFiles(buildManifest, '/_app'),
...buildManifest.pages[normalizePagePath('/_error')] ...getPageFiles(buildManifest, '/_error')
]) ])
] ]