mirror of
https://github.com/terribleplan/next.js.git
synced 2024-01-19 02:48:18 +00:00
Though it sounds like some folks do run getDataFromTree() on the client in order to avoid loading states, it's non-standard usage and potentially confusing. Also it's inconsistent with the other with-apollo examples.
This commit is contained in:
parent
254681d95a
commit
8f61c335cb
|
@ -39,26 +39,26 @@ export default App => {
|
||||||
return {}
|
return {}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Run all graphql queries in the component tree
|
|
||||||
// and extract the resulting data
|
|
||||||
try {
|
|
||||||
// Run all GraphQL queries
|
|
||||||
await getDataFromTree(
|
|
||||||
<App
|
|
||||||
{...appProps}
|
|
||||||
Component={Component}
|
|
||||||
router={router}
|
|
||||||
apolloClient={apollo}
|
|
||||||
/>
|
|
||||||
)
|
|
||||||
} catch (error) {
|
|
||||||
// Prevent Apollo Client GraphQL errors from crashing SSR.
|
|
||||||
// Handle them in components via the data.error prop:
|
|
||||||
// https://www.apollographql.com/docs/react/api/react-apollo.html#graphql-query-data-error
|
|
||||||
console.error('Error while running `getDataFromTree`', error)
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!process.browser) {
|
if (!process.browser) {
|
||||||
|
// Run all graphql queries in the component tree
|
||||||
|
// and extract the resulting data
|
||||||
|
try {
|
||||||
|
// Run all GraphQL queries
|
||||||
|
await getDataFromTree(
|
||||||
|
<App
|
||||||
|
{...appProps}
|
||||||
|
Component={Component}
|
||||||
|
router={router}
|
||||||
|
apolloClient={apollo}
|
||||||
|
/>
|
||||||
|
)
|
||||||
|
} catch (error) {
|
||||||
|
// Prevent Apollo Client GraphQL errors from crashing SSR.
|
||||||
|
// Handle them in components via the data.error prop:
|
||||||
|
// https://www.apollographql.com/docs/react/api/react-apollo.html#graphql-query-data-error
|
||||||
|
console.error('Error while running `getDataFromTree`', error)
|
||||||
|
}
|
||||||
|
|
||||||
// getDataFromTree does not call componentWillUnmount
|
// getDataFromTree does not call componentWillUnmount
|
||||||
// head side effect therefore need to be cleared manually
|
// head side effect therefore need to be cleared manually
|
||||||
Head.rewind()
|
Head.rewind()
|
||||||
|
|
Loading…
Reference in a new issue