terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

[with-apollo-auth] Only run getDataFromTree() on server (fix #4775) (#5112)

Browse source 
Though it sounds like some folks do run getDataFromTree() on the client in order to avoid loading states, it's non-standard usage and potentially confusing.  Also it's inconsistent with the other with-apollo examples.
This commit is contained in:
Keith Grennan 2018-09-06 00:45:16 -07:00 committed by Tim Neutkens
parent 254681d95a
commit 8f61c335cb
1 changed files with 19 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
examples/with-apollo-auth/lib/withApollo.js
View file

@ -39,6 +39,7 @@ export default App => {
return {} return {}
} }
if (!process.browser) {
// Run all graphql queries in the component tree // Run all graphql queries in the component tree
// and extract the resulting data // and extract the resulting data
try { try {
@ -58,7 +59,6 @@ export default App => {
console.error('Error while running `getDataFromTree`', error) console.error('Error while running `getDataFromTree`', error)
} }
if (!process.browser) {
// getDataFromTree does not call componentWillUnmount // getDataFromTree does not call componentWillUnmount
// head side effect therefore need to be cleared manually // head side effect therefore need to be cleared manually
Head.rewind() Head.rewind()