terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

Move react{-dom,} to the common chunk in production too (#3690)

Browse source 
Without this, react-dom gets included in multiple pages.
This commit is contained in:
Bertrand Marron 2018-02-06 10:08:53 +01:00 committed by Arunoda Susiripala
parent efed85e495
commit 8942d20b8c
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
server/build/webpack.js
View file

@ -250,11 +250,11 @@ export default async function getBaseWebpackConfig (dir, {dev = false, isServer
// We need to move react-dom explicitly into common chunks. // We need to move react-dom explicitly into common chunks.
// Otherwise, if some other page or module uses it, it might // Otherwise, if some other page or module uses it, it might
// included in that bundle too. // included in that bundle too.
if (dev && module.context && module.context.indexOf(`${sep}react${sep}`) >= 0) { if (module.context && module.context.indexOf(`${sep}react${sep}`) >= 0) {
return true return true
} }
if (dev && module.context && module.context.indexOf(`${sep}react-dom${sep}`) >= 0) { if (module.context && module.context.indexOf(`${sep}react-dom${sep}`) >= 0) {
return true return true
} }