From 7b62ef3ba6643900e87470b5453bde0ebc95ebee Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Thu, 15 Jun 2017 01:46:45 +0700 Subject: [PATCH] Upgrade beta version of next for "with-dynamic-import" example (#2262) * temporary commit * fixed eslint & parse error when precommit * upgrade new beta version for stability --- examples/with-dynamic-import/package.json | 2 +- flyfile.js | 29 ++++++++++++----------- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/examples/with-dynamic-import/package.json b/examples/with-dynamic-import/package.json index af172610..6db361dd 100644 --- a/examples/with-dynamic-import/package.json +++ b/examples/with-dynamic-import/package.json @@ -10,7 +10,7 @@ }, "dependencies": { "async-reactor": "^1.1.1", - "next": "^3.0.0-beta3", + "next": "^3.0.0-beta13", "react": "^15.4.2", "react-dom": "^15.4.2" }, diff --git a/flyfile.js b/flyfile.js index 7b5c3731..e7343d46 100644 --- a/flyfile.js +++ b/flyfile.js @@ -2,35 +2,35 @@ const notifier = require('node-notifier') const childProcess = require('child_process') const isWindows = /^win/.test(process.platform) -export async function compile(fly) { +export async function compile (fly) { await fly.parallel(['bin', 'server', 'lib', 'client']) } -export async function bin(fly, opts) { - await fly.source(opts.src || 'bin/*').babel().target('dist/bin', {mode: 0755}) +export async function bin (fly, opts) { + await fly.source(opts.src || 'bin/*').babel().target('dist/bin', {mode: parseInt('0755', 8)}) notify('Compiled binaries') } -export async function lib(fly, opts) { +export async function lib (fly, opts) { await fly.source(opts.src || 'lib/**/*.js').babel().target('dist/lib') notify('Compiled lib files') } -export async function server(fly, opts) { +export async function server (fly, opts) { await fly.source(opts.src || 'server/**/*.js').babel().target('dist/server') notify('Compiled server files') } -export async function client(fly, opts) { +export async function client (fly, opts) { await fly.source(opts.src || 'client/**/*.js').babel().target('dist/client') notify('Compiled client files') } -export async function copy(fly) { +export async function copy (fly) { await fly.source('pages/**/*.js').target('dist/pages') } -export async function build(fly) { +export async function build (fly) { await fly.serial(['copy', 'compile']) } @@ -43,7 +43,7 @@ export default async function (fly) { await fly.watch('lib/**/*.js', ['lib']) } -export async function release(fly) { +export async function release (fly) { await fly.clear('dist').start('build') } @@ -52,24 +52,25 @@ export async function release(fly) { // Even though we kill this task's process, chromedriver exists throughout // the lifetime of the original npm script. -export async function pretest(fly) { - const processName = isWindows ? 'chromedriver.cmd' : 'chromedriver' +export async function pretest (fly) { + const processName = isWindows ? 'chromedriver.cmd' : 'chromedriver' + // eslint-disable-next-line const chromedriver = childProcess.spawn(processName, { stdio: 'inherit' }) // We need to do this, otherwise this task's process will keep waiting. setTimeout(() => process.exit(0), 2000) } -export async function posttest(fly) { +export async function posttest (fly) { try { const cmd = isWindows ? 'taskkill /im chromedriver* /t /f' : 'pkill chromedriver' childProcess.execSync(cmd, { stdio: 'ignore' }) - } catch(err) { + } catch (err) { // Do nothing } } // notification helper -function notify(msg) { +function notify (msg) { return notifier.notify({ title: '▲ Next', message: msg,