terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

Run initializeStore() only once per route on server (#5644)

Browse source 
On the server `props.initialMobxState` received by the `constructor` is a fully functioning mobx store that was instantiated by `getInitialProps()` only a few ticks earlier.
Thus, creating a new instance is unneccessary.

In the browser, however, `props.initialMobxState` is a hydrated plain object and thus the store needs to be initialized.
This commit is contained in:
Már Örlygsson 2018-11-20 14:53:28 +00:00 committed by Tim Neutkens
parent 76202f2fb2
commit 766d7d5fe4
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
examples/with-mobx/pages/_app.js
View file

@ -21,7 +21,10 @@ class MyMobxApp extends App {
constructor(props) {
super(props)
this.mobxStore = initializeStore(props.initialMobxState)
const isServer = typeof window === 'undefined'
this.mobxStore = isServer ?
props.initialMobxState:
initializeStore(props.initialMobxState)
}
render() {