From 49fea51f349e36c9acc38bd0843835c671f0926f Mon Sep 17 00:00:00 2001 From: Jayden Seric Date: Thu, 10 Jan 2019 22:53:43 +1100 Subject: [PATCH] Fix Head.propTypes (#6020) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This PR fixes the buggy `Head.propTypes` here: https://github.com/zeit/next.js/blob/v8.0.0-canary.3/packages/next-server/lib/head.js#L107 Currently, `Head.propTypes` allows one child node like this: ```jsx import Head from 'next/head' // … Title ``` But more than one child node mistakenly causes a prop type error like this: ```jsx Title ``` ``` Warning: Failed prop type: Invalid prop `children` supplied to `Head`. ``` --- packages/next-server/lib/head.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/next-server/lib/head.js b/packages/next-server/lib/head.js index e1701421..8998a1b1 100644 --- a/packages/next-server/lib/head.js +++ b/packages/next-server/lib/head.js @@ -104,7 +104,7 @@ if (process.env.NODE_ENV === 'development') { const exact = require('prop-types-exact') Head.propTypes = exact({ - children: PropTypes.oneOfType([PropTypes.element, PropTypes.arrayOf(PropTypes.element)]).isRequired + children: PropTypes.node.isRequired }) }