terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

Send credentials with on-demand-entries-ping (#5053)

Browse source 
In my use case, the client pings are failing since the requests do not send basic auth credentials right now.

This change was made in https://github.com/zeit/next.js/pull/2509

I am not sure why it was undone as a part of https://github.com/zeit/next.js/pull/3578

Can someone explain why? Thanks.
This commit is contained in:
Nikhil Fadnis 2018-08-29 18:22:15 +05:30 committed by Tim Neutkens
parent 99c509e449
commit 48e4c771c2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
client/on-demand-entries-client.js
View file

@ -12,14 +12,14 @@ export default ({assetPrefix}) => {
try { try {
const url = `${assetPrefix || ''}/_next/on-demand-entries-ping?page=${Router.pathname}` const url = `${assetPrefix || ''}/_next/on-demand-entries-ping?page=${Router.pathname}`
const res = await fetch(url, { const res = await fetch(url, {
credentials: 'omit' credentials: 'same-origin'
}) })
const payload = await res.json() const payload = await res.json()
if (payload.invalid) { if (payload.invalid) {
// Payload can be invalid even if the page is not exists. // Payload can be invalid even if the page is not exists.
// So, we need to make sure it's exists before reloading. // So, we need to make sure it's exists before reloading.
const pageRes = await fetch(location.href, { const pageRes = await fetch(location.href, {
credentials: 'omit' credentials: 'same-origin'
}) })
if (pageRes.status === 200) { if (pageRes.status === 200) {
location.reload() location.reload()