terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

Avoid autoscrolling anchored URLs (#474)

Browse source 
* force scroll to false if # is found in url

* only overwrite scroll if scroll=true is not passed in

* clean up logic around setting scroll var
This commit is contained in:
James O'Dwyer 2016-12-22 03:15:49 -05:00 committed by Naoyuki Kanezawa
parent eb9a61e9e7
commit 31feced24a
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/link.js
View file

@ -14,7 +14,7 @@ export default class Link extends Component {
return return
} }
const { href, scroll, as } = this.props const { href, as } = this.props
if (!isLocal(href)) { if (!isLocal(href)) {
// ignore click if it's outside our scope // ignore click if it's outside our scope
@ -26,6 +26,12 @@ export default class Link extends Component {
const route = as ? href : null const route = as ? href : null
const url = as || href const url = as || href
// avoid scroll for urls with anchor refs
let { scroll } = this.props
if (scroll == null) {
scroll = url.indexOf('#') < 0
}
// straight up redirect // straight up redirect
Router.push(route, url) Router.push(route, url)
.then((success) => { .then((success) => {