terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

Fix paths when built on windows (#5795)

Browse source 
This PR Fixes #4920

So the problem is that when a next.js application is built on windows, the `pages-manifest.json` file is created with backslashes. If this built application is deployed to a linux hosting enviroment, the server will fail when trying to load the modules.

```
Error: Cannot find module '/user_code/next/server/bundles\pages\index.js
```

My simple solution is to modify the `pages-manifest.json` to always use linux separator (`/`), then also
modify `server/require.js` to, when requiring page, replace any separator (`\` or `/`) with current platform-specific file separator (`require('path').sep`).

The fix in `server/require.js` would be sufficient, but my opinion is that having some cross-platform consistency is nice.

This change was tested by bulding an application in windows and running it in linux and windows, aswell as building an application in linux and running it in linux and windows. The related tests was also run.
# Conflicts:
#	test/integration/production/test/index.test.js
This commit is contained in:
Oscar Busk 2018-12-10 12:14:29 +01:00 committed by Tim Neutkens
parent 6a75118247
commit 27c0b199d0
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/next/build/webpack/plugins/pages-manifest-plugin.js
View file

@ -23,7 +23,8 @@ export default class PagesManifestPlugin {
}
const {name} = entry
pages[`/${pagePath.replace(/\\/g, '/')}`] = name
// Write filename, replace any backslashes in path (on windows) with forwardslashes for cross-platform consistency.
pages[`/${pagePath.replace(/\\/g, '/')}`] = name.replace(/\\/g, '/')
}
if (typeof pages['/index'] !== 'undefined') {

13
test/integration/production/test/index.test.js
View file

@ -16,7 +16,7 @@ import fetch from 'node-fetch'
import dynamicImportTests from './dynamic'
import processEnv from './process-env'
import security from './security'
import {BUILD_MANIFEST, REACT_LOADABLE_MANIFEST} from 'next-server/constants'
import {BUILD_MANIFEST, REACT_LOADABLE_MANIFEST, PAGES_MANIFEST} from 'next-server/constants'
const appDir = join(__dirname, '../')
let appPort
@ -319,6 +319,17 @@ describe('Production Usage', () => {
expect(serverSideJsBody).toMatch(/404/)
})
it('should not put backslashes in pages-manifest.json', () => {
// Whatever platform you build on, pages-manifest.json should use forward slash (/)
// See: https://github.com/zeit/next.js/issues/4920
const pagesManifest = require(join('..', '.next', 'server', PAGES_MANIFEST))
for (let key of Object.keys(pagesManifest)) {
expect(key).not.toMatch(/\\/)
expect(pagesManifest[key]).not.toMatch(/\\/)
}
})
it('should handle failed param decoding', async () => {
const html = await renderViaHTTP(appPort, '/%DE~%C7%1fY/')
expect(html).toMatch(/400/)