terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

More reliable error-recovery tests (#5281)

Browse source 
As they were failing intermittently, this PR tries to solve that.
This commit is contained in:
Tim Neutkens 2018-09-25 16:54:03 +02:00 committed by GitHub
parent bb06f50747
commit 139bc40fb5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 47 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
test/integration/basic/test/error-recovery.js
View file

@ -1,7 +1,7 @@
/* global describe, it, expect */
import webdriver from 'next-webdriver'
import { join } from 'path'
import { check, File, waitFor, getReactErrorOverlayContent } from 'next-test-utils'
import { check, File, getReactErrorOverlayContent } from 'next-test-utils'
export default (context, render) => {
describe('Error Recovery', () => {
@ -13,9 +13,6 @@ export default (context, render) => {
try {
browser = await webdriver(context.appPort, '/hmr/about')
// Wait for react-error-overlay
await browser.waitForElementByCss('iframe', 2000)
// react-error-overlay uses the following inline style if an editorHandler is installed
expect(await getReactErrorOverlayContent(browser)).toMatch(/style="cursor: pointer;"/)
@ -45,8 +42,6 @@ export default (context, render) => {
aboutPage.replace('</div>', 'div')
await waitFor(10000)
expect(await getReactErrorOverlayContent(browser)).toMatch(/Unterminated JSX contents/)
aboutPage.restore()
@ -64,34 +59,6 @@ export default (context, render) => {
}
})
it('should not show the default HMR error overlay', async () => {
let browser
const aboutPage = new File(join(__dirname, '../', 'pages', 'hmr', 'about.js'))
try {
browser = await webdriver(context.appPort, '/hmr/about')
const text = await browser
.elementByCss('p').text()
expect(text).toBe('This is the about page.')
aboutPage.replace('</div>', 'div')
await waitFor(10000)
expect(await getReactErrorOverlayContent(browser)).toMatch(/Unterminated JSX contents/)
await waitFor(10000)
// Check for the error overlay
const bodyHtml = await browser.elementByCss('body').getAttribute('innerHTML')
expect(bodyHtml.includes('webpack-hot-middleware-clientOverlay')).toBeFalsy()
} finally {
aboutPage.restore()
if (browser) {
browser.close()
}
}
})
it('should show the error on all pages', async () => {
const aboutPage = new File(join(__dirname, '../', 'pages', 'hmr', 'about.js'))
let browser
@ -100,8 +67,6 @@ export default (context, render) => {
browser = await webdriver(context.appPort, '/hmr/contact')
await waitFor(10000)
expect(await getReactErrorOverlayContent(browser)).toMatch(/Unterminated JSX contents/)
aboutPage.restore()
@ -129,8 +94,6 @@ export default (context, render) => {
aboutPage.replace('export', 'aa=20;\nexport')
await waitFor(10000)
expect(await getReactErrorOverlayContent(browser)).toMatch(/aa is not defined/)
aboutPage.restore()
@ -156,8 +119,6 @@ export default (context, render) => {
const aboutPage = new File(join(__dirname, '../', 'pages', 'hmr', 'about.js'))
aboutPage.replace('return', 'throw new Error("an-expected-error");\nreturn')
await waitFor(10000)
expect(await getReactErrorOverlayContent(browser)).toMatch(/an-expected-error/)
aboutPage.restore()
@ -179,9 +140,10 @@ export default (context, render) => {
const aboutPage = new File(join(__dirname, '../', 'pages', 'hmr', 'about.js'))
aboutPage.replace('export default', 'export default "not-a-page"\nexport const fn = ')
await waitFor(10000)
expect(await browser.elementByCss('body').text()).toMatch(/The default export is not a React Component/)
await check(
() => browser.elementByCss('body').text(),
/The default export is not a React Component/
)
aboutPage.restore()
@ -221,8 +183,6 @@ export default (context, render) => {
const browser = await webdriver(context.appPort, '/hmr')
await browser.elementByCss('#error-in-gip-link').click()
await waitFor(10000)
expect(await getReactErrorOverlayContent(browser)).toMatch(/an-expected-error-in-gip/)
const erroredPage = new File(join(__dirname, '../', 'pages', 'hmr', 'error-in-gip.js'))
@ -240,8 +200,6 @@ export default (context, render) => {
it('should recover after an error reported via SSR', async () => {
const browser = await webdriver(context.appPort, '/hmr/error-in-gip')
await waitFor(10000)
expect(await getReactErrorOverlayContent(browser)).toMatch(/an-expected-error-in-gip/)
const erroredPage = new File(join(__dirname, '../', 'pages', 'hmr', 'error-in-gip.js'))

2
test/lib/next-test-utils.js
View file

@ -216,6 +216,8 @@ export async function getReactErrorOverlayContent (browser) {
}, 1000 * 30)
while (!found) {
try {
await browser.waitForElementByCss('iframe', 10000)
const hasIframe = await browser.hasElementByCssSelector('iframe')
if (!hasIframe) {
throw new Error('Waiting for iframe')