terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

Allow Duplicate Open Graph Image Tags (#4851)

Browse source 
* allow og:image duplicates

* add tests

* update tests

* fix spacing
This commit is contained in:
Gary Meehan 2018-08-12 20:51:17 +01:00 committed by Tim Neutkens
parent e8c1eaec83
commit 0f4e9feafa
3 changed files with 29 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/head.js
View file

@ -49,7 +49,7 @@ function onStateChange (head) {
}
const METATYPES = ['name', 'httpEquiv', 'charSet', 'itemProp', 'property']
const ALLOWED_DUPLICATES = ['article:tag']
const ALLOWED_DUPLICATES = ['article:tag', 'og:image', 'og:image:alt', 'og:image:width', 'og:image:height', 'og:image:type', 'og:image:secure_url', 'og:image:url']
/*
returns a function for filtering head child elements

14
test/integration/basic/pages/head.js
View file

@ -15,6 +15,20 @@ export default () => <div>
<meta property='article:tag' content='tag2' key='tag2key' />
<meta property='dedupe:tag' content='tag3' key='tag3key' />
<meta property='dedupe:tag' content='tag4' key='tag4key' />
<meta property='og:image' content='ogImageTag1' key='ogImageTag1Key' />
<meta property='og:image' content='ogImageTag2' key='ogImageTag2Key' />
<meta property='og:image:alt' content='ogImageAltTag1' key='ogImageAltTag1Key' />
<meta property='og:image:alt' content='ogImageAltTag2' key='ogImageAltTag2Key' />
<meta property='og:image:width' content='ogImageWidthTag1' key='ogImageWidthTag1Key' />
<meta property='og:image:width' content='ogImageWidthTag2' key='ogImageWidthTag2Key' />
<meta property='og:image:height' content='ogImageHeightTag1' key='ogImageHeightTag1Key' />
<meta property='og:image:height' content='ogImageHeightTag2' key='ogImageHeightTag2Key' />
<meta property='og:image:type' content='ogImageTypeTag1' key='ogImageTypeTag1Key' />
<meta property='og:image:type' content='ogImageTypeTag2' key='ogImageTypeTag2Key' />
<meta property='og:image:secure_url' content='ogImageSecureUrlTag1' key='ogImageSecureUrlTag1Key' />
<meta property='og:image:secure_url' content='ogImageSecureUrlTag2' key='ogImageSecureUrlTag2Key' />
<meta property='og:image:url' content='ogImageUrlTag1' key='ogImageUrlTag1Key' />
<meta property='og:image:url' content='ogImageUrlTag2' key='ogImageUrlTag2Key' />
<React.Fragment>
<title>Fragment title</title>

14
test/integration/basic/test/rendering.js
View file

@ -49,6 +49,20 @@ export default function ({ app }, suiteName, render, fetch) {
expect(html).toContain('<meta property="article:tag" content="tag2" class="next-head"/>')
expect(html).not.toContain('<meta property="dedupe:tag" content="tag3" class="next-head"/>')
expect(html).toContain('<meta property="dedupe:tag" content="tag4" class="next-head"/>')
expect(html).toContain('<meta property="og:image" content="ogImageTag1" class="next-head"/>')
expect(html).toContain('<meta property="og:image" content="ogImageTag2" class="next-head"/>')
expect(html).toContain('<meta property="og:image:alt" content="ogImageAltTag1" class="next-head"/>')
expect(html).toContain('<meta property="og:image:alt" content="ogImageAltTag2" class="next-head"/>')
expect(html).toContain('<meta property="og:image:width" content="ogImageWidthTag1" class="next-head"/>')
expect(html).toContain('<meta property="og:image:width" content="ogImageWidthTag2" class="next-head"/>')
expect(html).toContain('<meta property="og:image:height" content="ogImageHeightTag1" class="next-head"/>')
expect(html).toContain('<meta property="og:image:height" content="ogImageHeightTag2" class="next-head"/>')
expect(html).toContain('<meta property="og:image:type" content="ogImageTypeTag1" class="next-head"/>')
expect(html).toContain('<meta property="og:image:type" content="ogImageTypeTag2" class="next-head"/>')
expect(html).toContain('<meta property="og:image:secure_url" content="ogImageSecureUrlTag1" class="next-head"/>')
expect(html).toContain('<meta property="og:image:secure_url" content="ogImageSecureUrlTag2" class="next-head"/>')
expect(html).toContain('<meta property="og:image:url" content="ogImageUrlTag1" class="next-head"/>')
expect(html).toContain('<meta property="og:image:url" content="ogImageUrlTag2" class="next-head"/>')
})
test('header helper renders Fragment children', async () => {