terribleplan/next.js
1
0
Fork 0
mirror of https://github.com/terribleplan/next.js.git synced 2024-01-19 02:48:18 +00:00
Code Issues Releases Wiki Activity

docs: don't blow away existing query string (#1638)

Browse source 
* docs: don't blow away existing query string

See comments in diff - I ran across this and it took me a while to work out why my client side code worked, but the server didn't. It was because I didn't realise that `.render`'s 3rd arg was the query object, so it was losing the _actual_ query string.

* chore: remove trailing spaces

¯\_(ツ)_/¯ I think!
This commit is contained in:
Remy Sharp 2017-04-07 18:01:40 +01:00 committed by Guillermo Rauch
parent feb62816e0
commit 0487956c47
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
examples/parameterized-routing/server.js
View file

@ -12,14 +12,16 @@ const match = route('/blog/:id')
app.prepare() app.prepare()
.then(() => { .then(() => {
createServer((req, res) => { createServer((req, res) => {
const { pathname } = parse(req.url) const { pathname, query } = parse(req.url, true)
const params = match(pathname) const params = match(pathname)
if (params === false) { if (params === false) {
handle(req, res) handle(req, res)
return return
} }
// assigning `query` into the params means that we still
app.render(req, res, '/blog', params) // get the query string passed to our application
// i.e. /blog/foo?show-comments=true
app.render(req, res, '/blog', Object.assign(params, query))
}) })
.listen(3000, (err) => { .listen(3000, (err) => {
if (err) throw err if (err) throw err