nrd.li/mastodon
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Reduce wasted renders for column_loading.js (#5021)

Browse source 
* Reduce wasted renders for column_loading.js

* Use defaultProps
This commit is contained in:
Nolan Lawson 2017-09-20 10:58:44 -07:00 committed by Eugen Rochko
parent 8fcfcddc8f
commit 798b0fc5af
1 changed files with 22 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
app/javascript/mastodon/features/ui/components/column_loading.js
View file

@ -3,17 +3,28 @@ import PropTypes from 'prop-types';
import Column from '../../../components/column'; import Column from '../../../components/column';
import ColumnHeader from '../../../components/column_header'; import ColumnHeader from '../../../components/column_header';
import ImmutablePureComponent from 'react-immutable-pure-component';
const ColumnLoading = ({ title = '', icon = ' ' }) => ( export default class ColumnLoading extends ImmutablePureComponent {
<Column>
<ColumnHeader icon={icon} title={title} multiColumn={false} focusable={false} />
<div className='scrollable' />
</Column>
);
ColumnLoading.propTypes = { static propTypes = {
title: PropTypes.node, title: PropTypes.oneOfType(PropTypes.node, PropTypes.string),
icon: PropTypes.string, icon: PropTypes.string,
}; };
export default ColumnLoading; static defaultProps = {
title: '',
icon: '',
};
render() {
let { title, icon } = this.props;
return (
<Column>
<ColumnHeader icon={icon} title={title} multiColumn={false} focusable={false} />
<div className='scrollable' />
</Column>
);
}
}