Reduce wasted renders for column_loading.js (#5021)
* Reduce wasted renders for column_loading.js * Use defaultProps
This commit is contained in:
parent
8fcfcddc8f
commit
798b0fc5af
|
@ -3,17 +3,28 @@ import PropTypes from 'prop-types';
|
||||||
|
|
||||||
import Column from '../../../components/column';
|
import Column from '../../../components/column';
|
||||||
import ColumnHeader from '../../../components/column_header';
|
import ColumnHeader from '../../../components/column_header';
|
||||||
|
import ImmutablePureComponent from 'react-immutable-pure-component';
|
||||||
|
|
||||||
const ColumnLoading = ({ title = '', icon = ' ' }) => (
|
export default class ColumnLoading extends ImmutablePureComponent {
|
||||||
|
|
||||||
|
static propTypes = {
|
||||||
|
title: PropTypes.oneOfType(PropTypes.node, PropTypes.string),
|
||||||
|
icon: PropTypes.string,
|
||||||
|
};
|
||||||
|
|
||||||
|
static defaultProps = {
|
||||||
|
title: '',
|
||||||
|
icon: '',
|
||||||
|
};
|
||||||
|
|
||||||
|
render() {
|
||||||
|
let { title, icon } = this.props;
|
||||||
|
return (
|
||||||
<Column>
|
<Column>
|
||||||
<ColumnHeader icon={icon} title={title} multiColumn={false} focusable={false} />
|
<ColumnHeader icon={icon} title={title} multiColumn={false} focusable={false} />
|
||||||
<div className='scrollable' />
|
<div className='scrollable' />
|
||||||
</Column>
|
</Column>
|
||||||
);
|
);
|
||||||
|
}
|
||||||
|
|
||||||
ColumnLoading.propTypes = {
|
}
|
||||||
title: PropTypes.node,
|
|
||||||
icon: PropTypes.string,
|
|
||||||
};
|
|
||||||
|
|
||||||
export default ColumnLoading;
|
|
||||||
|
|
Reference in a new issue