58a4f350a8
This patch refactors gun pooling to use Elixir process registry and simplifies adapter option insertion. Having the pool use process registry instead of a GenServer has a number of advantages: - Simpler code: the initial implementation adds about half the lines of code it deletes - Concurrency: unlike a GenServer, ETS-based registry can handle multiple checkout/checkin requests at the same time - Precise and easy idle connection clousure: current proposal for closing idle connections in the GenServer-based pool needs to filter through all connections once a minute and compare their last active time with closing time. With Elixir process registry this can be done by just using `Process.send_after`/`Process.cancel_timer` in the worker process. - Lower memory footprint: In my tests `gun-memory-leak` branch uses about 290mb on peak load (250 connections) and 235mb on idle (5-10 connections). Registry-based pool uses 210mb on idle and 240mb on peak load
32 lines
814 B
Elixir
32 lines
814 B
Elixir
defmodule Pleroma.HTTP.AdapterHelper.Hackney do
|
|
@behaviour Pleroma.HTTP.AdapterHelper
|
|
|
|
@defaults [
|
|
connect_timeout: 10_000,
|
|
recv_timeout: 20_000,
|
|
follow_redirect: true,
|
|
force_redirect: true,
|
|
pool: :federation
|
|
]
|
|
|
|
@spec options(keyword(), URI.t()) :: keyword()
|
|
def options(connection_opts \\ [], %URI{} = uri) do
|
|
proxy = Pleroma.Config.get([:http, :proxy_url])
|
|
|
|
config_opts = Pleroma.Config.get([:http, :adapter], [])
|
|
|
|
@defaults
|
|
|> Keyword.merge(config_opts)
|
|
|> Keyword.merge(connection_opts)
|
|
|> add_scheme_opts(uri)
|
|
|> Pleroma.HTTP.AdapterHelper.maybe_add_proxy(proxy)
|
|
end
|
|
|
|
defp add_scheme_opts(opts, _), do: opts
|
|
|
|
def after_request(_), do: :ok
|
|
|
|
@spec get_conn(URI.t(), keyword()) :: {:ok, keyword()}
|
|
def get_conn(_uri, opts), do: {:ok, opts}
|
|
end
|