Also make this maybe_ for consistency
This commit is contained in:
parent
b22b12f738
commit
af37a5c51a
|
@ -38,7 +38,7 @@ def run(["resend_confirmation_emails"]) do
|
|||
invisible: false
|
||||
})
|
||||
|> Pleroma.Repo.chunk_stream(500)
|
||||
|> Stream.each(&Pleroma.User.try_send_confirmation_email(&1))
|
||||
|> Stream.each(&Pleroma.User.maybe_send_confirmation_email(&1))
|
||||
|> Stream.run()
|
||||
end
|
||||
end
|
||||
|
|
|
@ -798,7 +798,7 @@ def register(%Ecto.Changeset{} = changeset) do
|
|||
end
|
||||
|
||||
def post_register_action(%User{is_confirmed: false} = user) do
|
||||
with {:ok, _} <- try_send_confirmation_email(user) do
|
||||
with {:ok, _} <- maybe_send_confirmation_email(user) do
|
||||
{:ok, user}
|
||||
end
|
||||
end
|
||||
|
@ -870,8 +870,8 @@ defp maybe_send_welcome_email(%User{email: email} = user) when is_binary(email)
|
|||
|
||||
defp maybe_send_welcome_email(_), do: {:ok, :noop}
|
||||
|
||||
@spec try_send_confirmation_email(User.t()) :: {:ok, :enqueued | :noop}
|
||||
def try_send_confirmation_email(%User{is_confirmed: false, email: email} = user)
|
||||
@spec maybe_send_confirmation_email(User.t()) :: {:ok, :enqueued | :noop}
|
||||
def maybe_send_confirmation_email(%User{is_confirmed: false, email: email} = user)
|
||||
when is_binary(email) do
|
||||
if Config.get([:instance, :account_activation_required]) do
|
||||
send_confirmation_email(user)
|
||||
|
@ -881,7 +881,7 @@ def try_send_confirmation_email(%User{is_confirmed: false, email: email} = user)
|
|||
end
|
||||
end
|
||||
|
||||
def try_send_confirmation_email(_), do: {:ok, :noop}
|
||||
def maybe_send_confirmation_email(_), do: {:ok, :noop}
|
||||
|
||||
@spec send_confirmation_email(Uset.t()) :: User.t()
|
||||
def send_confirmation_email(%User{} = user) do
|
||||
|
|
|
@ -56,7 +56,7 @@ def confirmation_resend(conn, params) do
|
|||
nickname_or_email = params[:email] || params[:nickname]
|
||||
|
||||
with %User{} = user <- User.get_by_nickname_or_email(nickname_or_email),
|
||||
{:ok, _} <- User.try_send_confirmation_email(user) do
|
||||
{:ok, _} <- User.maybe_send_confirmation_email(user) do
|
||||
json_response(conn, :no_content, "")
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in a new issue