Update note count in ActivityPub.create.

lib/pleroma/web/activity_pub/activity_pub.ex

@@ -61,7 +61,8 @@ def create(%{to: to, actor: actor, context: context, object: object} = params) d
              additional
            ),
          {:ok, activity} <- insert(create_data, local),
-         :ok <- maybe_federate(activity) do
+         :ok <- maybe_federate(activity),
+         {:ok, actor} <- User.increase_note_count(actor) do
       {:ok, activity}
     end
   end

lib/pleroma/web/ostatus/handlers/note_handler.ex

@@ -138,19 +138,15 @@ def handle_note(entry, doc \\ nil) do
              do: note |> Map.put("inReplyTo", inReplyTo),
              else: note
            ) do
-      res =
-        ActivityPub.create(%{
-          to: to,
-          actor: actor,
-          context: context,
-          object: note,
-          published: date,
-          local: false,
-          additional: %{"cc" => cc}
-        })
-
-      User.increase_note_count(actor)
-      res
+      ActivityPub.create(%{
+        to: to,
+        actor: actor,
+        context: context,
+        object: note,
+        published: date,
+        local: false,
+        additional: %{"cc" => cc}
+      })
     else
       %Activity{} = activity -> {:ok, activity}
       e -> {:error, e}

test/web/activity_pub/activity_pub_test.exs

@@ -83,16 +83,18 @@ test "adds an id to a given object if it lacks one and is a note and inserts it
 
   describe "create activities" do
     test "removes doubled 'to' recipients" do
+      user = insert(:user)
+
       {:ok, activity} =
         ActivityPub.create(%{
           to: ["user1", "user1", "user2"],
-          actor: %User{ap_id: "1"},
+          actor: user,
           context: "",
           object: %{}
         })
 
       assert activity.data["to"] == ["user1", "user2"]
-      assert activity.actor == "1"
+      assert activity.actor == user.ap_id
       assert activity.recipients == ["user1", "user2"]
     end
   end