6006 commits

Author	SHA1	Message	Date
Lioncash	2cc0ef83cf	filesystem: Remove pragma disabling global optimizations ... This was just an artifact missed during PR review.	2018-07-19 10:30:53 -04:00
Lioncash	f317080f40	fsp_srv: Make IStorage constructor explicit ... Prevents implicit conversions.	2018-07-19 10:04:16 -04:00
Lioncash	910ad2e110	fsp_srv: Add missing includes ... Gets rid of relying on indirect inclusions.	2018-07-19 10:03:17 -04:00
Lioncash	6be342118a	fsp_srv: Resolve sign-mismatch warnings in assertion comparisons	2018-07-19 09:58:32 -04:00
Lioncash	d6e9b96e2f	fsp_srv: Respect write length in Write() ... Previously we were just copying the data whole-sale, even if the length was less than the total data size. This effectively makes the actual_data vector useless, which is likely not intended. Instead, amend this to only copy the given length amount of data. At the same time, we can avoid zeroing out the data before using it by passing iterators to the constructor instead of a size.	2018-07-19 09:57:48 -04:00
Lioncash	5c47ea1a4e	common/swap: Remove unnecessary const on return value of swap()	2018-07-19 09:35:54 -04:00
Lioncash	0a868641fa	common/swap: Use static_cast where applicable	2018-07-19 09:35:13 -04:00
Lioncash	1edf4dd7ef	common/swap: Use using aliases where applicable	2018-07-19 09:32:13 -04:00
Lioncash	9128271292	common/common_funcs: Remove unused rotation functions ... These are unused and essentially don't provide much benefit either. If we ever need rotation functions, these can be introduced in a way that they don't sit in a common_* header and require a bunch of ifdefing to simply be available	2018-07-19 09:21:23 -04:00
Lioncash	e0b8a35937	common/misc: Deduplicate code in GetLastErrorMsg() ... Android and macOS have supported thread_local for quite a while, but most importantly is that we don't even really need it. Instead of using a thread-local buffer, we can just return a non-static buffer as a std::string, avoiding the need for that quality entirely.	2018-07-19 09:15:38 -04:00
Lioncash	63e64f0131	file_util: return string by const reference for GetExeDirectory() ... This disallows modifying the internal string buffer (which shouldn't be modified anyhow).	2018-07-19 01:27:29 -04:00
Lioncash	33fbcb45a7	string_util: Remove AsciiToHex() ... Easy TODO	2018-07-18 23:57:15 -04:00
bunnei	368e1d25be	Merge pull request #692 from lioncash/assign ... address_arbiter: Correct assignment within an assertion statement in WakeThreads()	2018-07-18 20:56:28 -07:00
bunnei	85421f3406	Merge pull request #690 from lioncash/move ... core/memory, core/hle/kernel: Use std::move where applicable	2018-07-18 20:55:55 -07:00
Lioncash	88ba94e8a2	savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function ... This function doesn't alter class state.	2018-07-18 23:50:07 -04:00
Lioncash	9abc5763b6	partition_filesystem: Ensure all class members of PartitionFilesystem are initialized ... Previously is_hfs and pfs_header members wouldn't be initialized in the constructor, as they were stored in locals instead. This would result in things like GetName() and PrintDebugInfo() behaving incorrectly. While we're at it, initialize the members to deterministic values as well, in case loading ever fails.	2018-07-18 23:45:22 -04:00
bunnei	cf30c4be22	gl_state: Temporarily disable culling and depth test.	2018-07-18 23:21:43 -04:00
Lioncash	4790bb907d	content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference ... There's no need to take this by value when it's possible to avoid unnecessary copies entirely like this.	2018-07-18 23:19:28 -04:00
Lioncash	87a9bb392b	content_archive: Add missing standard includes	2018-07-18 23:18:59 -04:00
Lioncash	0b566f43a1	content_archive: std::move VirtualFile in NCA's constructor ... Gets rid of unnecessary atomic reference count incrementing and decrementing.	2018-07-18 23:13:25 -04:00
Lioncash	5e626c774f	vfs: Deduplicate accumulation code in VfsDirectory's GetSize() ... We can just use a generic lambda to avoid writing the same thing twice.	2018-07-18 23:03:27 -04:00
bunnei	1371e2fb6a	Merge pull request #691 from lioncash/guard ... service/prepo: Add missing header guard	2018-07-18 19:46:14 -07:00
bunnei	b10905c8ae	Merge pull request #686 from lioncash/fmt ... externals: update fmt to version 5.1.0	2018-07-18 19:44:44 -07:00
Lioncash	55ab369043	loader/nro: Resolve sign mismatch warnings	2018-07-18 22:27:22 -04:00
Lioncash	1831b5ef62	loader/nso: Remove unnecessary vector resizes ... We can just initialize these vectors directly via their constructor.	2018-07-18 22:26:41 -04:00
Lioncash	e3a30ccc7c	loader/nso: Resolve sign mismatch warnings	2018-07-18 22:26:37 -04:00
bunnei	90ce935f3d	Merge pull request #688 from lioncash/comma ... vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()	2018-07-18 18:59:09 -07:00
bunnei	3f93279047	Merge pull request #693 from lioncash/unused ... core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()	2018-07-18 18:57:13 -07:00
bunnei	49b0966003	Merge pull request #687 from lioncash/instance ... core: Don't construct instance of Core::System, just to access its live instance	2018-07-18 18:55:58 -07:00
bunnei	89f0acfd36	Merge pull request #680 from bunnei/fix-swizz ... decoders: Fix calc of swizzle image_width_in_gobs.	2018-07-18 18:55:37 -07:00
bunnei	2975f7820e	Merge pull request #684 from lioncash/nonmember ... game_list: Make ContainsAllWords an internally linked non-member function	2018-07-18 18:55:00 -07:00
bunnei	b496a9eefe	decoders: Fix calc of swizzle image_width_in_gobs.	2018-07-18 21:42:52 -04:00
Zach Hilman	29aff8d5ab	Virtual Filesystem 2: Electric Boogaloo (#676) ... * Virtual Filesystem * Fix delete bug and documentate * Review fixes + other stuff * Fix puyo regression	2018-07-18 18:07:11 -07:00
Lioncash	72207577b2	core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()	2018-07-18 19:55:46 -04:00
Lioncash	2cd3141c30	address_arbiter: Correct assignment within an assertion statement in WakeThreads() ... This was introduced within 4f81bc4e1b, and considering there's no comment indicating that this is intentional, this is very likely a bug.	2018-07-18 19:46:46 -04:00
Lioncash	296e68fd43	service/prepo: Add missing header guard	2018-07-18 19:43:28 -04:00
Lioncash	93cba6f699	vm_manager: Add missing commas to string literal array elements in GetMemoryStateName() ... Without these, this would perform concatenation, which is definitely not what we want here.	2018-07-18 19:37:19 -04:00
Lioncash	46458e7284	core/memory, core/hle/kernel: Use std::move where applicable ... Avoids pointless copies	2018-07-18 19:34:31 -04:00
Lioncash	10d2ab8098	core: Make System's default constructor private ... This makes it a compilation error to construct additional instances of the System class directly, preventing accidental wasteful constructions over and over.	2018-07-18 18:18:27 -04:00
Lioncash	3a4841e403	core: Don't construct instance of Core::System, just to access its live instance ... This would result in a lot of allocations and related object construction, just to toss it all away immediately after the call. These are definitely not intentional, and it was intended that all of these should have been accessing the static function GetInstance() through the name itself, not constructed instances.	2018-07-18 18:18:27 -04:00
Lioncash	f5d7706ca1	externals: update fmt to version 5.1.0 ... Previously, we were on 4.1.0, which was a major version behind.	2018-07-18 17:46:17 -04:00
Lioncash	d17e172d92	game_list: Make ContainsAllWords an internally linked non-member function ... This function actually depends on no internal class state, so it doesn't even need to be a part of the class interface.	2018-07-18 16:52:14 -04:00
Zach Hilman	c337272ca9	Fill in more fields in TouchScreenEntryTouch	2018-07-18 16:33:11 -04:00
Zach Hilman	f2f368014e	Single touch support	2018-07-18 14:06:33 -04:00
bunnei	3d1e8f750c	Merge pull request #681 from lioncash/const ... game_list: Make containsAllWords a const member function	2018-07-18 10:02:58 -07:00
bunnei	e3da9fc367	Merge pull request #682 from lioncash/telemetry ... Telemetry: Minor changes	2018-07-18 10:02:46 -07:00
bunnei	24a55bba42	Merge pull request #679 from lioncash/ctor ... game_list: Remove unnecessary QString initialization in KeyReleaseEater	2018-07-17 22:18:39 -07:00
bunnei	b87a71b3fe	Merge pull request #678 from lioncash/astc ... astc: Minor changes	2018-07-17 22:06:20 -07:00
Lioncash	c65a8fafa0	telemetry: Remove unnecessary Field constructor ... We can just take the value parameter by value which allows both moving into it, and copies at the same time, depending on the calling code.	2018-07-18 00:32:35 -04:00
Lioncash	0aebe6b3d5	telemetry: Make operator== and operator!= const member functions of Field ... These operators don't modify internal class state, so they can be made const member functions. While we're at it, drop the unnecessary inline keywords. Member functions that are defined in the class declaration are already inline by default.	2018-07-18 00:28:47 -04:00
Lioncash	3575d367a4	telemetry: Default copy/move constructors and assignment operators ... This provides the equivalent behavior, but without as much boilerplate. While we're at it, explicitly default the move constructor, since we have a move-assignment operator defined.	2018-07-18 00:25:12 -04:00
Lioncash	f4b98a857b	game_list: Upper-case containsAllWords to ContainsAllWords() ... This makes it consistent with most of the other private utility functions.	2018-07-18 00:15:48 -04:00
Lioncash	c8f3fc9a4b	game_list: Make containsAllWords a const member function ... This doesn't actually modify the internal class state, so it can be a const member function. While we're at it, amend the function to take its arguments by const reference.	2018-07-18 00:13:04 -04:00
Lioncash	f4c69149f9	game_list: Remove unnecessary QString initialization in KeyReleaseEater ... QString initializes to an empty string by default, so this does nothing meaningful. While we're at it, use a constructor initializer list for initializing the gamelist member variable.	2018-07-18 00:07:47 -04:00
Lioncash	6a03badcbc	astc: Initialize vector size directly in Decompress ... There's no need to perform a separate resize.	2018-07-17 23:58:14 -04:00
Lioncash	0f148548f3	astc: Mark functions as internally linked where applicable	2018-07-17 23:58:14 -04:00
Lioncash	c5803e30d3	astc: const-correctness changes where applicable ... A few member functions didn't actually modify class state, so these can be amended as necessary.	2018-07-17 23:58:14 -04:00
Lioncash	e3fadb9616	astc: Delete Bits' copy contstructor and assignment operator ... This also potentially avoids warnings, considering the copy assignment operator is supposed to have a return value.	2018-07-17 23:58:14 -04:00
Lioncash	4cd52a34b9	astc: In-class initialize member variables where appropriate	2018-07-17 23:58:10 -04:00
bunnei	03c2d049d4	settings: Turn docked mode off by default.	2018-07-17 22:52:25 -04:00
bunnei	49e5de9f03	vi: Change TransactionId::CancelBuffer to LOG_CRITICAL.	2018-07-17 22:47:35 -04:00
bunnei	0d1a99edf6	vi: Fix size for ListDisplays default display.	2018-07-17 22:18:14 -04:00
bunnei	c3dd456d51	vi: Partially implement buffer crop parameters.	2018-07-17 20:13:17 -04:00
bunnei	8e28af6f89	Merge pull request #675 from Subv/stencil ... GPU: Added register definitions for the stencil parameters.	2018-07-17 15:53:00 -07:00
Subv	3d3b10adc7	GPU: Added register definitions for the stencil parameters.	2018-07-17 15:00:21 -05:00
Zach Hilman	69bfe075b5	General Filesystem and Save Data Fixes (#670)	2018-07-17 12:42:15 -07:00
bunnei	88a3140c9b	Merge pull request #671 from MerryMage/clear-exclusive-state ... scheduler: Clear exclusive state when switching contexts	2018-07-17 07:33:32 -07:00
bunnei	519035db3d	Merge pull request #672 from SciresM/to_address_fix ... svc:: Fix bug in svcWaitForAddress	2018-07-17 07:32:42 -07:00
bunnei	170e19d4ea	nvflinger: Fix for BufferQueue event handling.	2018-07-17 00:26:23 -04:00
Michael Scire	3b885691a1	Kernel/Arbiter: Fix bug in WaitIfLessThan	2018-07-16 20:55:53 -06:00
MerryMage	56cc1c11ec	scheduler: Clear exclusive state when switching contexts	2018-07-16 11:24:00 +01:00
bunnei	068668780c	Merge pull request #668 from jroweboy/controller-lag ... HID: Update controllers less often	2018-07-15 13:06:28 -07:00
bunnei	04b9cde4f5	Merge pull request #664 from jroweboy/logging-stuff ... Minor logging improvements	2018-07-15 12:58:52 -07:00
James Rowe	7d209b3c9f	HID: Update controllers less often	2018-07-15 13:47:41 -06:00
James Rowe	497b81558e	Logging: Dump all logs in the queue on close in debug mode	2018-07-15 13:02:09 -06:00
bunnei	3a96670f2d	gl_rasterizer_cache: Implement texture format G8R8.	2018-07-15 01:33:42 -04:00
bunnei	aaec0b7e70	Merge pull request #665 from bunnei/fix-z24-s8 ... gl_rasterizer_cache: Fix incorrect offset in ConvertS8Z24ToZ24S8.	2018-07-14 22:18:55 -07:00
bunnei	3145114190	gl_rasterizer_cache: Fix incorrect offset in ConvertS8Z24ToZ24S8.	2018-07-15 00:02:05 -04:00
bunnei	e21190f47f	gl_rasterizer_cache: Implement depth format Z16_UNORM.	2018-07-14 23:43:28 -04:00
bunnei	2cb3fdca86	Merge pull request #598 from bunnei/makedonecurrent ... OpenGL: Use MakeCurrent/DoneCurrent for multithreaded rendering.	2018-07-14 20:18:11 -07:00
bunnei	c324a378ac	Merge pull request #663 from Subv/bsd ... Services/BSD: Corrected the return for StartMonitoring according to SwIPC	2018-07-14 19:40:34 -07:00
bunnei	fd1f5c5414	Merge pull request #662 from Subv/delete_file ... FileSys: Append the requested path to the filesystem base path in DeleteFile	2018-07-14 13:11:58 -07:00
James Rowe	6daebaaa57	Logging: Don't lock the queue for the duration of the write	2018-07-14 11:57:13 -06:00
Subv	b07f4d6afb	Services/BSD: Corrected the return for StartMonitoring according to SwIPC.	2018-07-14 12:34:07 -05:00
Subv	7e5e4f8d7a	FileSys: Append the requested path to the filesystem base path in DeleteFile. ... We were trying to delete things in the current directory instead of the actual filesystem directory. This may fix some savedata issues in some games.	2018-07-14 10:57:22 -05:00
David Marcec	a7d6c0d6ea	No need to use ASSERT_MSG with an empty message	2018-07-14 23:13:16 +10:00
bunnei	05cb10530f	OpenGL: Use MakeCurrent/DoneCurrent for multithreaded rendering.	2018-07-14 02:50:35 -04:00
Subv	b37354cca8	GPU: Always enable the depth write when clearing the depth buffer. ... The GPU ignores that register when clearing, but OpenGL obeys the glDepthMask parameter, so we set the depth mask to GL_TRUE when clearing the depth buffer. It will be restored to the correct value automatically on the next draw call.	2018-07-14 00:52:23 -05:00
bunnei	9fc0d1d701	Merge pull request #657 from bunnei/dual-vs ... gl_shader_gen: Implement dual vertex shader mode.	2018-07-13 07:08:54 -07:00
Hedges	e066bc75b9	More improvements to GDBStub (#653) ... * More improvements to GDBStub - Debugging of threads should work correctly with source and assembly level stepping and modifying registers and memory, meaning threads and callstacks are fully clickable in VS. - List of modules is available to the client, with assumption that .nro and .nso are backed up by an .elf with symbols, while deconstructed ROMs keep N names. - Initial support for floating point registers. * Tidy up as requested in PR feedback * Tidy up as requested in PR feedback	2018-07-12 20:22:59 -07:00
bunnei	8aeff9cf8e	gl_rasterizer: Fix check for if a shader stage is enabled.	2018-07-12 22:57:57 -04:00
bunnei	c4015cd93a	gl_shader_gen: Implement dual vertex shader mode. ... - When VertexA shader stage is enabled, we combine with VertexB program to make a single Vertex Shader stage.	2018-07-12 22:25:36 -04:00
bunnei	ce23ae3ede	Merge pull request #656 from ogniK5377/audren-mem-init ... Initialized memory for RequestUpdateAudioRenderer and fixed MemoryPoolSection to be more accurate	2018-07-12 19:12:47 -07:00
bunnei	64b5e5d5d9	Merge pull request #655 from bunnei/pred-lt-nan ... gl_shader_decompiler: Implement PredCondition::LessThanWithNan.	2018-07-12 18:59:15 -07:00
David Marcec	8bd8d1e3da	We only need to alert for memory pool changes	2018-07-13 10:36:28 +10:00
David Marcec	6642011706	initialized voice status and unused sizes in the update data header	2018-07-13 10:35:44 +10:00
bunnei	49c0c081c4	gl_shader_decompiler: Implement PredCondition::LessThanWithNan.	2018-07-12 20:04:35 -04:00
bunnei	4757ffdcce	gl_shader_decompiler: Use FlowCondition field in EXIT instruction.	2018-07-12 20:00:37 -04:00
Sebastian Valle	274d1fb0fc	Merge pull request #652 from Subv/fadd32i ... GPU: Implement the FADD32I shader instruction.	2018-07-12 17:36:51 -05:00
bunnei	3ff21345b4	Merge pull request #651 from Subv/ffma_decode ... GPU: Corrected the decoding of FFMA for immediate operands.	2018-07-12 12:42:58 -07:00