gitlab-com-suyu-emu/suyu
1
0
Fork 0
mirror of https://gitlab.com/suyu-emu/suyu.git synced 2024-03-15 23:15:44 +00:00
Code Issues Projects Releases Wiki Activity

core: Remove always true conditionals in Load()

Browse source 
These conditions are always true, since the outer conditional already
checks for these conditions.
This commit is contained in:
Lioncash 2018-08-24 02:48:28 -04:00
parent 165c23c848
commit 8492ec1669
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/core/core.cpp
View file

@ -135,8 +135,7 @@ System::ResultStatus System::Load(Frontend::EmuWindow& emu_window, const std::st
LOG_CRITICAL(Core, "Failed to determine system mode (Error {})!", LOG_CRITICAL(Core, "Failed to determine system mode (Error {})!",
static_cast<int>(system_mode.second)); static_cast<int>(system_mode.second));
if (system_mode.second != Loader::ResultStatus::Success) return ResultStatus::ErrorSystemMode;
return ResultStatus::ErrorSystemMode;
} }
ResultStatus init_result{Init(emu_window)}; ResultStatus init_result{Init(emu_window)};
@ -148,14 +147,12 @@ System::ResultStatus System::Load(Frontend::EmuWindow& emu_window, const std::st
} }
const Loader::ResultStatus load_result{app_loader->Load(current_process)}; const Loader::ResultStatus load_result{app_loader->Load(current_process)};
if (Loader::ResultStatus::Success != load_result) { if (load_result != Loader::ResultStatus::Success) {
LOG_CRITICAL(Core, "Failed to load ROM (Error {})!", static_cast<int>(load_result)); LOG_CRITICAL(Core, "Failed to load ROM (Error {})!", static_cast<int>(load_result));
System::Shutdown(); System::Shutdown();
if (load_result != Loader::ResultStatus::Success) { return static_cast<ResultStatus>(static_cast<u32>(ResultStatus::ErrorLoader) +
return static_cast<ResultStatus>(static_cast<u32>(ResultStatus::ErrorLoader) + static_cast<u32>(load_result));
static_cast<u32>(load_result));
}
} }
status = ResultStatus::Success; status = ResultStatus::Success;
return status; return status;