mirror of
https://gitlab.com/suyu-emu/suyu.git
synced 2024-03-15 23:15:44 +00:00
string_util: Use emplace_back() in SplitString() instead of push_back()
This is equivalent to doing: push_back(std::string("")); which is likely not to cause issues, assuming a decent std::string implementation with small-string optimizations implemented in its design, however it's still a little unnecessary to copy that buffer regardless. Instead, we can use emplace_back() to directly construct the empty string within the std::vector instance, eliminating any possible overhead from the copy.
This commit is contained in:
parent
cd46b267f5
commit
26a157cd31
|
@ -162,8 +162,9 @@ void SplitString(const std::string& str, const char delim, std::vector<std::stri
|
||||||
std::istringstream iss(str);
|
std::istringstream iss(str);
|
||||||
output.resize(1);
|
output.resize(1);
|
||||||
|
|
||||||
while (std::getline(iss, *output.rbegin(), delim))
|
while (std::getline(iss, *output.rbegin(), delim)) {
|
||||||
output.push_back("");
|
output.emplace_back();
|
||||||
|
}
|
||||||
|
|
||||||
output.pop_back();
|
output.pop_back();
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue