gitlab-com-suyu-emu/suyu
1
0
Fork 0
mirror of https://gitlab.com/suyu-emu/suyu.git synced 2024-03-15 23:15:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #6143 from lat9nq/nvhost_null_memcpy

Browse source 
nvhost_ctrl_gpu: Avoid sending null pointer to memcpy
This commit is contained in:
bunnei 2021-04-07 16:50:22 -07:00 committed by GitHub
parent 535e50db1c 638c892edf
commit 262a70223f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp
View file

@ -248,7 +248,13 @@ NvResult nvhost_ctrl_gpu::ZBCSetTable(const std::vector<u8>& input, std::vector<
IoctlZbcSetTable params{}; IoctlZbcSetTable params{};
std::memcpy(&params, input.data(), input.size()); std::memcpy(&params, input.data(), input.size());
// TODO(ogniK): What does this even actually do? // TODO(ogniK): What does this even actually do?
// Prevent null pointer being passed as arg 1
if (output.empty()) {
LOG_WARNING(Service_NVDRV, "Avoiding passing null pointer to memcpy");
} else {
std::memcpy(output.data(), &params, output.size()); std::memcpy(output.data(), &params, output.size());
}
return NvResult::Success; return NvResult::Success;
} }