mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2024-01-19 02:48:24 +00:00
81debd73d4
Reported by hieu.hcmus, Today (24 minutes ago) What steps will reproduce the problem? 1.Create 2 volumes server same rack, replication type = 001 2.Upload a file 3.Delete file What is the expected output? What do you see instead? Expected output: File is deleted in both volume server But: file is only deleted in one volume server What version of the product are you using? On what operating system? 0.36 Please provide any additional information below. After remove NeedleValue from NeedleMap, the size = 0 and it causes the error. I uploaded the patch to fix this error
386 lines
9.7 KiB
Go
386 lines
9.7 KiB
Go
package storage
|
|
|
|
import (
|
|
"bytes"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"log"
|
|
"os"
|
|
"path"
|
|
"sync"
|
|
)
|
|
|
|
const (
|
|
SuperBlockSize = 8
|
|
)
|
|
|
|
type SuperBlock struct {
|
|
Version Version
|
|
ReplicaType ReplicationType
|
|
}
|
|
|
|
func (s *SuperBlock) Bytes() []byte {
|
|
header := make([]byte, SuperBlockSize)
|
|
header[0] = byte(s.Version)
|
|
header[1] = s.ReplicaType.Byte()
|
|
return header
|
|
}
|
|
|
|
type Volume struct {
|
|
Id VolumeId
|
|
dir string
|
|
dataFile *os.File
|
|
nm NeedleMapper
|
|
readOnly bool
|
|
|
|
SuperBlock
|
|
|
|
accessLock sync.Mutex
|
|
}
|
|
|
|
func NewVolume(dirname string, id VolumeId, replicationType ReplicationType) (v *Volume, e error) {
|
|
v = &Volume{dir: dirname, Id: id}
|
|
v.SuperBlock = SuperBlock{ReplicaType: replicationType}
|
|
e = v.load(true)
|
|
return
|
|
}
|
|
func LoadVolumeOnly(dirname string, id VolumeId) (v *Volume, e error) {
|
|
v = &Volume{dir: dirname, Id: id}
|
|
v.SuperBlock = SuperBlock{ReplicaType: CopyNil}
|
|
e = v.load(false)
|
|
return
|
|
}
|
|
func (v *Volume) load(alsoLoadIndex bool) error {
|
|
var e error
|
|
fileName := path.Join(v.dir, v.Id.String())
|
|
v.dataFile, e = os.OpenFile(fileName+".dat", os.O_RDWR|os.O_CREATE, 0644)
|
|
if e != nil {
|
|
if !os.IsPermission(e) {
|
|
return fmt.Errorf("cannot create Volume Data %s.dat: %s", fileName, e)
|
|
}
|
|
if v.dataFile, e = os.Open(fileName + ".dat"); e != nil {
|
|
return fmt.Errorf("cannot open Volume Data %s.dat: %s", fileName, e)
|
|
}
|
|
log.Printf("opening " + fileName + ".dat in READONLY mode")
|
|
v.readOnly = true
|
|
}
|
|
if v.ReplicaType == CopyNil {
|
|
e = v.readSuperBlock()
|
|
} else {
|
|
e = v.maybeWriteSuperBlock()
|
|
}
|
|
if e == nil && alsoLoadIndex {
|
|
var indexFile *os.File
|
|
if v.readOnly {
|
|
if indexFile, e = os.Open(fileName + ".idx"); e != nil && !os.IsNotExist(e) {
|
|
return fmt.Errorf("cannot open index file %s.idx: %s", fileName, e)
|
|
}
|
|
if indexFile != nil {
|
|
log.Printf("converting %s.idx to %s.cdb", fileName, fileName)
|
|
if e = ConvertIndexToCdb(fileName+".cdb", indexFile); e != nil {
|
|
log.Printf("error converting %s.idx to %s.cdb: %s", fileName, fileName)
|
|
} else {
|
|
indexFile.Close()
|
|
os.Remove(indexFile.Name())
|
|
indexFile = nil
|
|
}
|
|
}
|
|
v.nm, e = OpenCdbMap(fileName + ".cdb")
|
|
return e
|
|
} else {
|
|
indexFile, e = os.OpenFile(fileName+".idx", os.O_RDWR|os.O_CREATE, 0644)
|
|
if e != nil {
|
|
return fmt.Errorf("cannot create Volume Data %s.dat: %s", fileName, e)
|
|
}
|
|
}
|
|
v.nm, e = LoadNeedleMap(indexFile)
|
|
}
|
|
return e
|
|
}
|
|
func (v *Volume) Version() Version {
|
|
return v.SuperBlock.Version
|
|
}
|
|
func (v *Volume) Size() int64 {
|
|
v.accessLock.Lock()
|
|
defer v.accessLock.Unlock()
|
|
stat, e := v.dataFile.Stat()
|
|
if e == nil {
|
|
return stat.Size()
|
|
}
|
|
log.Printf("Failed to read file size %s %s\n", v.dataFile.Name(), e.Error())
|
|
return -1
|
|
}
|
|
func (v *Volume) Close() {
|
|
v.accessLock.Lock()
|
|
defer v.accessLock.Unlock()
|
|
v.nm.Close()
|
|
_ = v.dataFile.Close()
|
|
}
|
|
func (v *Volume) maybeWriteSuperBlock() error {
|
|
stat, e := v.dataFile.Stat()
|
|
if e != nil {
|
|
log.Printf("failed to stat datafile %s: %s", v.dataFile, e)
|
|
return e
|
|
}
|
|
if stat.Size() == 0 {
|
|
v.SuperBlock.Version = CurrentVersion
|
|
_, e = v.dataFile.Write(v.SuperBlock.Bytes())
|
|
if e != nil && os.IsPermission(e) {
|
|
//read-only, but zero length - recreate it!
|
|
if v.dataFile, e = os.Create(v.dataFile.Name()); e == nil {
|
|
if _, e = v.dataFile.Write(v.SuperBlock.Bytes()); e == nil {
|
|
v.readOnly = false
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return e
|
|
}
|
|
func (v *Volume) readSuperBlock() (err error) {
|
|
if _, err = v.dataFile.Seek(0, 0); err != nil {
|
|
return fmt.Errorf("cannot seek to the beginning of %s: %s", v.dataFile, err)
|
|
}
|
|
header := make([]byte, SuperBlockSize)
|
|
if _, e := v.dataFile.Read(header); e != nil {
|
|
return fmt.Errorf("cannot read superblock: %s", e)
|
|
}
|
|
v.SuperBlock, err = ParseSuperBlock(header)
|
|
return err
|
|
}
|
|
func ParseSuperBlock(header []byte) (superBlock SuperBlock, err error) {
|
|
superBlock.Version = Version(header[0])
|
|
if superBlock.ReplicaType, err = NewReplicationTypeFromByte(header[1]); err != nil {
|
|
err = fmt.Errorf("cannot read replica type: %s", err)
|
|
}
|
|
return
|
|
}
|
|
func (v *Volume) NeedToReplicate() bool {
|
|
return v.ReplicaType.GetCopyCount() > 1
|
|
}
|
|
|
|
func (v *Volume) isFileUnchanged(n *Needle) bool {
|
|
nv, ok := v.nm.Get(n.Id)
|
|
if ok && nv.Offset > 0 {
|
|
if _, err := v.dataFile.Seek(int64(nv.Offset)*NeedlePaddingSize, 0); err != nil {
|
|
return false
|
|
}
|
|
oldNeedle := new(Needle)
|
|
oldNeedle.Read(v.dataFile, nv.Size, v.Version())
|
|
if oldNeedle.Checksum == n.Checksum && bytes.Equal(oldNeedle.Data, n.Data) {
|
|
n.Size = oldNeedle.Size
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
func (v *Volume) write(n *Needle) (size uint32, err error) {
|
|
if v.readOnly {
|
|
err = fmt.Errorf("%s is read-only", v.dataFile)
|
|
return
|
|
}
|
|
v.accessLock.Lock()
|
|
defer v.accessLock.Unlock()
|
|
if v.isFileUnchanged(n) {
|
|
size = n.Size
|
|
return
|
|
}
|
|
var offset int64
|
|
if offset, err = v.dataFile.Seek(0, 2); err != nil {
|
|
return
|
|
}
|
|
|
|
//ensure file writing starting from aligned positions
|
|
if offset%NeedlePaddingSize != 0 {
|
|
offset = offset + (NeedlePaddingSize - offset%NeedlePaddingSize)
|
|
if offset, err = v.dataFile.Seek(offset, 0); err != nil {
|
|
return
|
|
}
|
|
}
|
|
|
|
if size, err = n.Append(v.dataFile, v.Version()); err != nil {
|
|
if e := v.dataFile.Truncate(offset); e != nil {
|
|
err = fmt.Errorf("%s\ncannot truncate %s: %s", err, v.dataFile, e)
|
|
}
|
|
return
|
|
}
|
|
nv, ok := v.nm.Get(n.Id)
|
|
if !ok || int64(nv.Offset)*NeedlePaddingSize < offset {
|
|
_, err = v.nm.Put(n.Id, uint32(offset/NeedlePaddingSize), n.Size)
|
|
}
|
|
return
|
|
}
|
|
|
|
func (v *Volume) delete(n *Needle) (uint32, error) {
|
|
if v.readOnly {
|
|
return 0, fmt.Errorf("%s is read-only", v.dataFile)
|
|
}
|
|
v.accessLock.Lock()
|
|
defer v.accessLock.Unlock()
|
|
nv, ok := v.nm.Get(n.Id)
|
|
//fmt.Println("key", n.Id, "volume offset", nv.Offset, "data_size", n.Size, "cached size", nv.Size)
|
|
if ok {
|
|
var err error
|
|
size := nv.Size
|
|
if err = v.nm.Delete(n.Id); err != nil {
|
|
return size, err
|
|
}
|
|
if _, err = v.dataFile.Seek(0, 2); err != nil {
|
|
return size, err
|
|
}
|
|
n.Data = make([]byte, 0)
|
|
_, err = n.Append(v.dataFile, v.Version())
|
|
return size, err
|
|
}
|
|
return 0, nil
|
|
}
|
|
|
|
func (v *Volume) read(n *Needle) (int, error) {
|
|
v.accessLock.Lock()
|
|
defer v.accessLock.Unlock()
|
|
nv, ok := v.nm.Get(n.Id)
|
|
if ok && nv.Offset > 0 {
|
|
if _, err := v.dataFile.Seek(int64(nv.Offset)*NeedlePaddingSize, 0); err != nil {
|
|
return -1, err
|
|
}
|
|
return n.Read(v.dataFile, nv.Size, v.Version())
|
|
}
|
|
return -1, errors.New("Not Found")
|
|
}
|
|
|
|
func (v *Volume) garbageLevel() float64 {
|
|
return float64(v.nm.DeletedSize()) / float64(v.ContentSize())
|
|
}
|
|
|
|
func (v *Volume) compact() error {
|
|
v.accessLock.Lock()
|
|
defer v.accessLock.Unlock()
|
|
|
|
filePath := path.Join(v.dir, v.Id.String())
|
|
return v.copyDataAndGenerateIndexFile(filePath+".cpd", filePath+".cpx")
|
|
}
|
|
func (v *Volume) commitCompact() error {
|
|
v.accessLock.Lock()
|
|
defer v.accessLock.Unlock()
|
|
_ = v.dataFile.Close()
|
|
var e error
|
|
if e = os.Rename(path.Join(v.dir, v.Id.String()+".cpd"), path.Join(v.dir, v.Id.String()+".dat")); e != nil {
|
|
return e
|
|
}
|
|
if e = os.Rename(path.Join(v.dir, v.Id.String()+".cpx"), path.Join(v.dir, v.Id.String()+".idx")); e != nil {
|
|
return e
|
|
}
|
|
if e = v.load(true); e != nil {
|
|
return e
|
|
}
|
|
return nil
|
|
}
|
|
func (v *Volume) freeze() error {
|
|
if v.readOnly {
|
|
return nil
|
|
}
|
|
nm, ok := v.nm.(*NeedleMap)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
v.accessLock.Lock()
|
|
defer v.accessLock.Unlock()
|
|
bn, _ := nakeFilename(v.dataFile.Name())
|
|
cdbFn := bn + ".cdb"
|
|
log.Printf("converting %s to %s", nm.indexFile.Name(), cdbFn)
|
|
err := DumpNeedleMapToCdb(cdbFn, nm)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if v.nm, err = OpenCdbMap(cdbFn); err != nil {
|
|
return err
|
|
}
|
|
nm.indexFile.Close()
|
|
os.Remove(nm.indexFile.Name())
|
|
v.readOnly = true
|
|
return nil
|
|
}
|
|
|
|
func ScanVolumeFile(dirname string, id VolumeId,
|
|
visitSuperBlock func(SuperBlock) error,
|
|
visitNeedle func(n *Needle, offset uint32) error) (err error) {
|
|
var v *Volume
|
|
if v, err = LoadVolumeOnly(dirname, id); err != nil {
|
|
return
|
|
}
|
|
if err = visitSuperBlock(v.SuperBlock); err != nil {
|
|
return
|
|
}
|
|
|
|
version := v.Version()
|
|
|
|
offset := uint32(SuperBlockSize)
|
|
n, rest, e := ReadNeedleHeader(v.dataFile, version)
|
|
if e != nil {
|
|
err = fmt.Errorf("cannot read needle header: %s", e)
|
|
return
|
|
}
|
|
for n != nil {
|
|
if err = n.ReadNeedleBody(v.dataFile, version, rest); err != nil {
|
|
err = fmt.Errorf("cannot read needle body: %s", err)
|
|
return
|
|
}
|
|
if err = visitNeedle(n, offset); err != nil {
|
|
return
|
|
}
|
|
offset += NeedleHeaderSize + rest
|
|
if n, rest, err = ReadNeedleHeader(v.dataFile, version); err != nil {
|
|
if err == io.EOF {
|
|
return nil
|
|
}
|
|
return fmt.Errorf("cannot read needle header: %s", err)
|
|
}
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
func (v *Volume) copyDataAndGenerateIndexFile(dstName, idxName string) (err error) {
|
|
var (
|
|
dst, idx *os.File
|
|
)
|
|
if dst, err = os.OpenFile(dstName, os.O_WRONLY|os.O_CREATE, 0644); err != nil {
|
|
return
|
|
}
|
|
defer dst.Close()
|
|
|
|
if idx, err = os.OpenFile(idxName, os.O_WRONLY|os.O_CREATE, 0644); err != nil {
|
|
return
|
|
}
|
|
defer idx.Close()
|
|
|
|
nm := NewNeedleMap(idx)
|
|
new_offset := uint32(SuperBlockSize)
|
|
|
|
err = ScanVolumeFile(v.dir, v.Id, func(superBlock SuperBlock) error {
|
|
_, err = dst.Write(superBlock.Bytes())
|
|
return err
|
|
}, func(n *Needle, offset uint32) error {
|
|
nv, ok := v.nm.Get(n.Id)
|
|
//log.Println("file size is", n.Size, "rest", rest)
|
|
if ok && nv.Offset*NeedlePaddingSize == offset {
|
|
if nv.Size > 0 {
|
|
if _, err = nm.Put(n.Id, new_offset/NeedlePaddingSize, n.Size); err != nil {
|
|
return fmt.Errorf("cannot put needle: %s", err)
|
|
}
|
|
if _, err = n.Append(dst, v.Version()); err != nil {
|
|
return fmt.Errorf("cannot append needle: %s", err)
|
|
}
|
|
new_offset += n.DiskSize()
|
|
//log.Println("saving key", n.Id, "volume offset", old_offset, "=>", new_offset, "data_size", n.Size, "rest", rest)
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
|
|
return
|
|
}
|
|
func (v *Volume) ContentSize() uint64 {
|
|
return v.nm.ContentSize()
|
|
}
|