correctly recursively delete folders

This commit is contained in:
Chris Lu 2018-08-01 01:26:41 -07:00
parent fa3ded4134
commit c81f1cda47

View file

@ -13,6 +13,7 @@ import (
"github.com/chrislusf/seaweedfs/weed/pb/filer_pb" "github.com/chrislusf/seaweedfs/weed/pb/filer_pb"
"github.com/chrislusf/seaweedfs/weed/wdclient" "github.com/chrislusf/seaweedfs/weed/wdclient"
"github.com/karlseguin/ccache" "github.com/karlseguin/ccache"
"math"
) )
type Filer struct { type Filer struct {
@ -141,7 +142,11 @@ func (f *Filer) DeleteEntryMetaAndData(p FullPath, isRecursive bool, shouldDelet
} }
if entry.IsDirectory() { if entry.IsDirectory() {
entries, err := f.ListDirectoryEntries(p, "", false, 1) limit := int(1)
if isRecursive {
limit = math.MaxInt32
}
entries, err := f.ListDirectoryEntries(p, "", false, limit)
if err != nil { if err != nil {
return fmt.Errorf("list folder %s: %v", p, err) return fmt.Errorf("list folder %s: %v", p, err)
} }
@ -161,6 +166,10 @@ func (f *Filer) DeleteEntryMetaAndData(p FullPath, isRecursive bool, shouldDelet
f.deleteChunks(entry.Chunks) f.deleteChunks(entry.Chunks)
} }
if p == "/" {
return nil
}
glog.V(0).Infof("deleting entry %v", p)
return f.store.DeleteEntry(p) return f.store.DeleteEntry(p)
} }