From bee482d49e34fdb40b3ebf07a4eb855659f191a0 Mon Sep 17 00:00:00 2001 From: Kaiwalya Joshi Date: Thu, 19 May 2022 14:48:32 -0700 Subject: [PATCH] fix: Remove invalid serviceName from s3-deployments template. Remove `deployments.spec.serviceName` from the s3 deployment template. `serviceName` isn't a valid field and causes issues when deploying the chart. This is the full output for `kubectl explain deployments.spec` ``` KIND: Deployment VERSION: apps/v1 RESOURCE: spec DESCRIPTION: Specification of the desired behavior of the Deployment. DeploymentSpec is the specification of the desired behavior of the Deployment. FIELDS: minReadySeconds Minimum number of seconds for which a newly created pod should be ready without any of its container crashing, for it to be considered available. Defaults to 0 (pod will be considered available as soon as it is ready) paused Indicates that the deployment is paused. progressDeadlineSeconds The maximum time in seconds for a deployment to make progress before it is considered to be failed. The deployment controller will continue to process failed deployments and a condition with a ProgressDeadlineExceeded reason will be surfaced in the deployment status. Note that progress will not be estimated during the time a deployment is paused. Defaults to 600s. replicas Number of desired pods. This is a pointer to distinguish between explicit zero and not specified. Defaults to 1. revisionHistoryLimit The number of old ReplicaSets to retain to allow rollback. This is a pointer to distinguish between explicit zero and not specified. Defaults to 10. selector -required- Label selector for pods. Existing ReplicaSets whose pods are selected by this will be the ones affected by this deployment. It must match the pod template's labels. strategy The deployment strategy to use to replace existing pods with new ones. template -required- Template describes the pods that will be created. ``` --- k8s/helm_charts2/templates/s3-deployment.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/k8s/helm_charts2/templates/s3-deployment.yaml b/k8s/helm_charts2/templates/s3-deployment.yaml index 2638c7f56..aac09f328 100644 --- a/k8s/helm_charts2/templates/s3-deployment.yaml +++ b/k8s/helm_charts2/templates/s3-deployment.yaml @@ -10,7 +10,6 @@ metadata: heritage: {{ .Release.Service }} release: {{ .Release.Name }} spec: - serviceName: {{ template "seaweedfs.name" . }}-s3 replicas: {{ .Values.s3.replicas }} selector: matchLabels: