refactor code

This commit is contained in:
guosj 2022-07-12 11:25:36 +08:00
parent 7dbf19d09a
commit b3076909d1

View file

@ -213,24 +213,19 @@ func (iama *IamApiServer) PutUserPolicy(s3cfg *iam_pb.S3ApiConfiguration, values
if err != nil { if err != nil {
return PutUserPolicyResponse{}, err return PutUserPolicyResponse{}, err
} }
isFound := false
policyDocuments[policyName] = &policyDocument policyDocuments[policyName] = &policyDocument
actions := GetActions(&policyDocument) actions := GetActions(&policyDocument)
for _, ident := range s3cfg.Identities { for _, ident := range s3cfg.Identities {
if userName != ident.Name { if userName != ident.Name {
continue continue
} }
isFound = true
for _, action := range actions { for _, action := range actions {
ident.Actions = append(ident.Actions, action) ident.Actions = append(ident.Actions, action)
} }
break
}
if !isFound {
return resp, fmt.Errorf("%s: the user with name %s cannot be found", iam.ErrCodeNoSuchEntityException, userName)
}
return resp, nil return resp, nil
} }
return resp, fmt.Errorf("%s: the user with name %s cannot be found", iam.ErrCodeNoSuchEntityException, userName)
}
func (iama *IamApiServer) GetUserPolicy(s3cfg *iam_pb.S3ApiConfiguration, values url.Values) (resp GetUserPolicyResponse, err error) { func (iama *IamApiServer) GetUserPolicy(s3cfg *iam_pb.S3ApiConfiguration, values url.Values) (resp GetUserPolicyResponse, err error) {
userName := values.Get("UserName") userName := values.Get("UserName")