From a6359738478213ce67c15491d3900c406206f20e Mon Sep 17 00:00:00 2001 From: Ryan Russell Date: Thu, 15 Sep 2022 04:03:10 -0500 Subject: [PATCH] docs(topology): readability improvements (#3688) Signed-off-by: Ryan Russell Signed-off-by: Ryan Russell --- weed/topology/store_replicate.go | 2 +- weed/topology/volume_layout_test.go | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/weed/topology/store_replicate.go b/weed/topology/store_replicate.go index bbca859ac..1f6fc0568 100644 --- a/weed/topology/store_replicate.go +++ b/weed/topology/store_replicate.go @@ -205,7 +205,7 @@ func GetWritableRemoteReplications(s *storage.Store, grpcDialOption grpc.DialOpt // has one local and has remote replications copyCount := v.ReplicaPlacement.GetCopyCount() if len(lookupResult.Locations) < copyCount { - err = fmt.Errorf("replicating opetations [%d] is less than volume %d replication copy count [%d]", + err = fmt.Errorf("replicating operations [%d] is less than volume %d replication copy count [%d]", len(lookupResult.Locations), volumeId, copyCount) } } diff --git a/weed/topology/volume_layout_test.go b/weed/topology/volume_layout_test.go index ce2fa0d19..b5646fb13 100644 --- a/weed/topology/volume_layout_test.go +++ b/weed/topology/volume_layout_test.go @@ -54,7 +54,7 @@ func TestVolumesBinaryState(t *testing.T) { expectResultAfterUpdate []bool }{ { - name: "mark true when exist copies", + name: "mark true when copies exist", state: state_exist, expectResult: []bool{true, true, true, false, true}, update: func() { @@ -67,7 +67,7 @@ func TestVolumesBinaryState(t *testing.T) { expectResultAfterUpdate: []bool{true, false, true, false, false}, }, { - name: "mark true when inexist copies", + name: "mark true when no copies exist", state: state_no, expectResult: []bool{false, true, true, false, true}, update: func() { @@ -92,7 +92,7 @@ func TestVolumesBinaryState(t *testing.T) { } for index, val := range result { if val != test.expectResult[index] { - t.Fatalf("result not matched, index %d, got %v, expect %v\n", + t.Fatalf("result not matched, index %d, got %v, expected %v\n", index, val, test.expectResult[index]) } } @@ -107,7 +107,7 @@ func TestVolumesBinaryState(t *testing.T) { } for index, val := range updateResult { if val != test.expectResultAfterUpdate[index] { - t.Fatalf("update result not matched, index %d, got %v, expect %v\n", + t.Fatalf("update result not matched, index %d, got %v, expected %v\n", index, val, test.expectResultAfterUpdate[index]) } }