From 9ba52db5858c480cb8cf4125b0d698f188f22ba8 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Sat, 26 Nov 2016 12:14:06 -0800 Subject: [PATCH] add writable checking fix https://github.com/chrislusf/seaweedfs/issues/405 --- weed/topology/topology_vacuum.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/weed/topology/topology_vacuum.go b/weed/topology/topology_vacuum.go index 3a6fcbae2..a7ef52336 100644 --- a/weed/topology/topology_vacuum.go +++ b/weed/topology/topology_vacuum.go @@ -86,7 +86,14 @@ func (t *Topology) Vacuum(garbageThreshold string) int { for _, vl := range c.storageType2VolumeLayout.Items() { if vl != nil { volumeLayout := vl.(*VolumeLayout) + writableSet := make(map[storage.VolumeId]bool) + for _, id := range volumeLayout.writables { + writableSet[id] = true + } for vid, locationlist := range volumeLayout.vid2location { + if _, isWritable := writableSet[vid]; !isWritable { + continue + } glog.V(0).Infof("check vacuum on collection:%s volume:%d", c.Name, vid) if batchVacuumVolumeCheck(volumeLayout, vid, locationlist, garbageThreshold) { if batchVacuumVolumeCompact(volumeLayout, vid, locationlist) {