Merge pull request #1173 from divinerapier/master

feat: drains http body if buffer is too small
This commit is contained in:
Chris Lu 2019-12-25 21:00:21 -08:00 committed by GitHub
commit 997f5ead93
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -235,8 +235,16 @@ func ReadUrl(fileUrl string, offset int64, size int, buf []byte, isReadRange boo
if err != nil {
return n, err
}
if n == int64(len(buf)) {
break
}
}
// drains the response body to avoid memory leak
data, err := ioutil.ReadAll(reader)
if len(data) != 0 {
err = fmt.Errorf("buffer size is too small. remains %d", len(data))
}
return n, err
}
func ReadUrlAsStream(fileUrl string, offset int64, size int, fn func(data []byte)) (int64, error) {