Merge pull request #1169 from stlpmo-jn/http_304_has_no_resp_body

remove the http 304 response body
This commit is contained in:
Chris Lu 2019-12-24 07:08:46 -08:00 committed by GitHub
commit 9114f7f432
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -51,10 +51,14 @@ func (vs *VolumeServer) PostHandler(w http.ResponseWriter, r *http.Request) {
ret := operation.UploadResult{}
_, isUnchanged, writeError := topology.ReplicatedWrite(vs.GetMaster(), vs.store, volumeId, needle, r)
httpStatus := http.StatusCreated
if isUnchanged {
httpStatus = http.StatusNotModified
// http 304 status code does not allow body
if writeError == nil && isUnchanged {
w.WriteHeader(http.StatusNotModified)
return
}
httpStatus := http.StatusCreated
if writeError != nil {
httpStatus = http.StatusInternalServerError
ret.Error = writeError.Error()