From 7a51a9a5823576aa540684aac6424b5793a9e285 Mon Sep 17 00:00:00 2001
From: Chris Lu <chris.lu@gmail.com>
Date: Fri, 25 Oct 2019 00:11:25 -0700
Subject: [PATCH] refactor: simplifying to ReadAt() and WriteAt()

---
 weed/storage/needle/needle_read_write.go | 2 +-
 weed/storage/volume_super_block.go       | 8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/weed/storage/needle/needle_read_write.go b/weed/storage/needle/needle_read_write.go
index 42736bda1..04308a8a7 100644
--- a/weed/storage/needle/needle_read_write.go
+++ b/weed/storage/needle/needle_read_write.go
@@ -154,7 +154,7 @@ func (n *Needle) Append(w *os.File, version Version) (offset uint64, size uint32
 		if exists {
 			mMap.WriteMemory(offset, uint64(len(bytesToWrite)), bytesToWrite)
 		} else {
-			_, err = w.Write(bytesToWrite)
+			_, err = w.WriteAt(bytesToWrite, int64(offset))
 		}
 	}
 
diff --git a/weed/storage/volume_super_block.go b/weed/storage/volume_super_block.go
index 2c2553666..cb34a2347 100644
--- a/weed/storage/volume_super_block.go
+++ b/weed/storage/volume_super_block.go
@@ -92,7 +92,7 @@ func (v *Volume) maybeWriteSuperBlock() error {
 		}
 		if stat.Size() == 0 {
 			v.SuperBlock.version = needle.CurrentVersion
-			_, e = v.dataFile.Write(v.SuperBlock.Bytes())
+			_, e = v.dataFile.WriteAt(v.SuperBlock.Bytes(), 0)
 			if e != nil && os.IsPermission(e) {
 				//read-only, but zero length - recreate it!
 				if v.dataFile, e = os.Create(v.dataFile.Name()); e == nil {
@@ -123,11 +123,7 @@ func ReadSuperBlock(dataFile *os.File) (superBlock SuperBlock, err error) {
 			return
 		}
 	} else {
-		if _, err = dataFile.Seek(0, 0); err != nil {
-			err = fmt.Errorf("cannot seek to the beginning of %s: %v", dataFile.Name(), err)
-			return
-		}
-		if _, e := dataFile.Read(header); e != nil {
+		if _, e := dataFile.ReadAt(header, 0); e != nil {
 			err = fmt.Errorf("cannot read volume %s super block: %v", dataFile.Name(), e)
 			return
 		}