Merge pull request #2104 from kmlebedev/sync_volume_on_close

avoid data loss after restarting a container with a volum server
This commit is contained in:
Chris Lu 2021-06-02 11:47:57 -07:00 committed by GitHub
commit 62142ff1d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -180,10 +180,16 @@ func (v *Volume) Close() {
v.dataFileAccessLock.Lock()
defer v.dataFileAccessLock.Unlock()
if v.nm != nil {
if err := v.nm.Sync(); err != nil {
glog.Warningf("Volume Close fail to sync volume idx %d", v.Id)
}
v.nm.Close()
v.nm = nil
}
if v.DataBackend != nil {
if err := v.DataBackend.Sync(); err != nil {
glog.Warningf("Volume Close fail to sync volume %d", v.Id)
}
_ = v.DataBackend.Close()
v.DataBackend = nil
stats.VolumeServerVolumeCounter.WithLabelValues(v.Collection, "volume").Dec()