refactoring

weed/filer/stream.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"io"
 	"math"
+	"sort"
 	"strings"
 	"time"
 
@@ -88,65 +89,61 @@ func ReadAll(masterClient *wdclient.MasterClient, chunks []*filer_pb.FileChunk)
 
 // ----------------  ChunkStreamReader ----------------------------------
 type ChunkStreamReader struct {
-	chunkViews   []*ChunkView
+	chunkViews         []*ChunkView
-	totalSize    int64
+	totalSize          int64
-	logicOffset  int64
+	buffer             []byte
-	buffer       []byte
+	bufferOffset       int64
-	bufferOffset int64
+	bufferPos          int
-	bufferPos    int
+	nextChunkViewIndex int
-	chunkIndex   int
+	lookupFileId       wdclient.LookupFileIdFunctionType
-	lookupFileId wdclient.LookupFileIdFunctionType
 }
 
 var _ = io.ReadSeeker(&ChunkStreamReader{})
 
+func doNewChunkStreamReader(lookupFileIdFn wdclient.LookupFileIdFunctionType, chunks []*filer_pb.FileChunk) *ChunkStreamReader {
+
+	chunkViews := ViewFromChunks(lookupFileIdFn, chunks, 0, math.MaxInt64)
+	sort.Slice(chunkViews, func(i, j int) bool {
+		return chunkViews[i].LogicOffset < chunkViews[j].LogicOffset
+	})
+
+	var totalSize int64
+	for _, chunk := range chunkViews {
+		totalSize += int64(chunk.Size)
+	}
+
+	return &ChunkStreamReader{
+		chunkViews:   chunkViews,
+		lookupFileId: lookupFileIdFn,
+		totalSize:    totalSize,
+	}
+}
+
 func NewChunkStreamReaderFromFiler(masterClient *wdclient.MasterClient, chunks []*filer_pb.FileChunk) *ChunkStreamReader {
 
 	lookupFileIdFn := func(fileId string) (targetUrl []string, err error) {
 		return masterClient.LookupFileId(fileId)
 	}
 
-	chunkViews := ViewFromChunks(lookupFileIdFn, chunks, 0, math.MaxInt64)
+	return doNewChunkStreamReader(lookupFileIdFn, chunks)
-
-	var totalSize int64
-	for _, chunk := range chunkViews {
-		totalSize += int64(chunk.Size)
-	}
-
-	return &ChunkStreamReader{
-		chunkViews:   chunkViews,
-		lookupFileId: lookupFileIdFn,
-		totalSize:    totalSize,
-	}
 }
 
 func NewChunkStreamReader(filerClient filer_pb.FilerClient, chunks []*filer_pb.FileChunk) *ChunkStreamReader {
 
 	lookupFileIdFn := LookupFn(filerClient)
 
-	chunkViews := ViewFromChunks(lookupFileIdFn, chunks, 0, math.MaxInt64)
+	return doNewChunkStreamReader(lookupFileIdFn, chunks)
-
-	var totalSize int64
-	for _, chunk := range chunkViews {
-		totalSize += int64(chunk.Size)
-	}
-
-	return &ChunkStreamReader{
-		chunkViews:   chunkViews,
-		lookupFileId: lookupFileIdFn,
-		totalSize:    totalSize,
-	}
 }
 
 func (c *ChunkStreamReader) Read(p []byte) (n int, err error) {
 	for n < len(p) {
 		if c.isBufferEmpty() {
-			if c.chunkIndex >= len(c.chunkViews) {
+			if c.nextChunkViewIndex >= len(c.chunkViews) {
 				return n, io.EOF
 			}
-			chunkView := c.chunkViews[c.chunkIndex]
+			chunkView := c.chunkViews[c.nextChunkViewIndex]
 			c.fetchChunkToBuffer(chunkView)
-			c.chunkIndex++
+			c.nextChunkViewIndex++
 		}
 		t := copy(p[n:], c.buffer[c.bufferPos:])
 		c.bufferPos += t
@@ -173,16 +170,33 @@ func (c *ChunkStreamReader) Seek(offset int64, whence int) (int64, error) {
 		err = io.ErrUnexpectedEOF
 	}
 
-	for i, chunk := range c.chunkViews {
+	// stay in the same chunk
-		if chunk.LogicOffset <= offset && offset < chunk.LogicOffset+int64(chunk.Size) {
+	if !c.isBufferEmpty() {
-			if c.isBufferEmpty() || c.bufferOffset != chunk.LogicOffset {
+		if c.bufferOffset <= offset && offset < c.bufferOffset+int64(len(c.buffer)) {
-				c.fetchChunkToBuffer(chunk)
+			c.bufferPos = int(offset - c.bufferOffset)
-				c.chunkIndex = i + 1
+			return offset, nil
-				break
-			}
 		}
 	}
-	c.bufferPos = int(offset - c.bufferOffset)
+
+	// need to seek to a different chunk
+	currentChunkIndex := sort.Search(len(c.chunkViews), func(i int) bool {
+		return c.chunkViews[i].LogicOffset <= offset
+	})
+	if currentChunkIndex == len(c.chunkViews) {
+		return 0, io.EOF
+	}
+
+	// positioning within the new chunk
+	chunk := c.chunkViews[currentChunkIndex]
+	if chunk.LogicOffset <= offset && offset < chunk.LogicOffset+int64(chunk.Size) {
+		if c.isBufferEmpty() || c.bufferOffset != chunk.LogicOffset {
+			c.fetchChunkToBuffer(chunk)
+			c.nextChunkViewIndex = currentChunkIndex + 1
+		}
+		c.bufferPos = int(offset - c.bufferOffset)
+	} else {
+		return 0, io.ErrUnexpectedEOF
+	}
 
 	return offset, err