Merge pull request #1129 from divinerapier/master

can not break out of from for-select block
This commit is contained in:
Chris Lu 2019-11-19 20:43:05 -08:00 committed by GitHub
commit 4f3adcb5ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -35,13 +35,12 @@ func batchVacuumVolumeCheck(grpcDialOption grpc.DialOption, vl *VolumeLayout, vi
}(index, dn.Url(), vid) }(index, dn.Url(), vid)
} }
isCheckSuccess := true isCheckSuccess := true
for _ = range locationlist.list { for range locationlist.list {
select { select {
case canVacuum := <-ch: case canVacuum := <-ch:
isCheckSuccess = isCheckSuccess && canVacuum isCheckSuccess = isCheckSuccess && canVacuum
case <-time.After(30 * time.Minute): case <-time.After(30 * time.Minute):
isCheckSuccess = false return false
break
} }
} }
return isCheckSuccess return isCheckSuccess
@ -71,13 +70,12 @@ func batchVacuumVolumeCompact(grpcDialOption grpc.DialOption, vl *VolumeLayout,
}(index, dn.Url(), vid) }(index, dn.Url(), vid)
} }
isVacuumSuccess := true isVacuumSuccess := true
for _ = range locationlist.list { for range locationlist.list {
select { select {
case canCommit := <-ch: case canCommit := <-ch:
isVacuumSuccess = isVacuumSuccess && canCommit isVacuumSuccess = isVacuumSuccess && canCommit
case <-time.After(30 * time.Minute): case <-time.After(30 * time.Minute):
isVacuumSuccess = false return false
break
} }
} }
return isVacuumSuccess return isVacuumSuccess