From 43a5973a66052e63a2bcb609d198481ea508ca80 Mon Sep 17 00:00:00 2001 From: Lars Lehtonen Date: Wed, 6 Dec 2023 11:31:18 -0800 Subject: [PATCH] weed/storage: fix dropped test errors --- weed/storage/idx_binary_search_test.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/weed/storage/idx_binary_search_test.go b/weed/storage/idx_binary_search_test.go index 07eacb898..0f26cdd02 100644 --- a/weed/storage/idx_binary_search_test.go +++ b/weed/storage/idx_binary_search_test.go @@ -32,6 +32,9 @@ func TestFirstInvalidIndex(t *testing.T) { } } b, err := os.ReadFile(v.IndexFileName() + ".idx") + if err != nil { + t.Fatal(err) + } // base case every record is valid -> nothing is filtered index, err := idx.FirstInvalidIndex(b, func(key types.NeedleId, offset types.Offset, size types.Size) (bool, error) { return true, nil @@ -43,16 +46,25 @@ func TestFirstInvalidIndex(t *testing.T) { index, err = idx.FirstInvalidIndex(b, func(key types.NeedleId, offset types.Offset, size types.Size) (bool, error) { return false, nil }) + if err != nil { + t.Fatal(err) + } assert.Equal(t, 0, index, "when every record is invalid everything should be filtered from binary search") index, err = idx.FirstInvalidIndex(b, func(key types.NeedleId, offset types.Offset, size types.Size) (bool, error) { return key < 20, nil }) + if err != nil { + t.Fatal(err) + } // needle key range from 1 to 30 so < 20 means 19 keys are valid and cutoff the bytes at 19 * 16 = 304 assert.Equal(t, 19, index, "when every record is invalid everything should be filtered from binary search") index, err = idx.FirstInvalidIndex(b, func(key types.NeedleId, offset types.Offset, size types.Size) (bool, error) { return key <= 1, nil }) + if err != nil { + t.Fatal(err) + } // needle key range from 1 to 30 so <=1 1 means 1 key is valid and cutoff the bytes at 1 * 16 = 16 assert.Equal(t, 1, index, "when every record is invalid everything should be filtered from binary search") }