mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2024-01-19 02:48:24 +00:00
master api: return http 404 when volumeId not exist
Signed-off-by: Lei Liu <lei01.liu@horizon.ai>
This commit is contained in:
parent
972e881d48
commit
3cc084269c
|
@ -67,7 +67,6 @@ func main() {
|
||||||
}(d)
|
}(d)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
counter := int64(0)
|
counter := int64(0)
|
||||||
lastResetTime := time.Now()
|
lastResetTime := time.Now()
|
||||||
|
|
||||||
|
|
|
@ -2,14 +2,13 @@ package main
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"flag"
|
"flag"
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
"path/filepath"
|
||||||
|
|
||||||
"github.com/chrislusf/seaweedfs/weed/glog"
|
"github.com/chrislusf/seaweedfs/weed/glog"
|
||||||
"github.com/chrislusf/seaweedfs/weed/storage"
|
"github.com/chrislusf/seaweedfs/weed/storage"
|
||||||
"github.com/chrislusf/seaweedfs/weed/storage/needle"
|
"github.com/chrislusf/seaweedfs/weed/storage/needle"
|
||||||
"os"
|
|
||||||
"path/filepath"
|
|
||||||
|
|
||||||
"fmt"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
var (
|
var (
|
||||||
|
|
|
@ -2,12 +2,11 @@ package main
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"flag"
|
"flag"
|
||||||
|
"time"
|
||||||
|
|
||||||
"github.com/chrislusf/seaweedfs/weed/glog"
|
"github.com/chrislusf/seaweedfs/weed/glog"
|
||||||
"github.com/chrislusf/seaweedfs/weed/storage"
|
"github.com/chrislusf/seaweedfs/weed/storage"
|
||||||
"github.com/chrislusf/seaweedfs/weed/storage/needle"
|
"github.com/chrislusf/seaweedfs/weed/storage/needle"
|
||||||
|
|
||||||
"time"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
var (
|
var (
|
||||||
|
@ -45,5 +44,4 @@ func main() {
|
||||||
if err != nil {
|
if err != nil {
|
||||||
glog.Fatalf("Reading Volume File [ERROR] %s\n", err)
|
glog.Fatalf("Reading Volume File [ERROR] %s\n", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -48,7 +48,7 @@ func (ms *MasterServer) dirLookupHandler(w http.ResponseWriter, r *http.Request)
|
||||||
collection := r.FormValue("collection") //optional, but can be faster if too many collections
|
collection := r.FormValue("collection") //optional, but can be faster if too many collections
|
||||||
location := ms.findVolumeLocation(collection, vid)
|
location := ms.findVolumeLocation(collection, vid)
|
||||||
httpStatus := http.StatusOK
|
httpStatus := http.StatusOK
|
||||||
if location.Error != "" {
|
if location.Error != "" || location.Locations == nil {
|
||||||
httpStatus = http.StatusNotFound
|
httpStatus = http.StatusNotFound
|
||||||
} else {
|
} else {
|
||||||
forRead := r.FormValue("read")
|
forRead := r.FormValue("read")
|
||||||
|
@ -60,7 +60,7 @@ func (ms *MasterServer) dirLookupHandler(w http.ResponseWriter, r *http.Request)
|
||||||
|
|
||||||
// findVolumeLocation finds the volume location from master topo if it is leader,
|
// findVolumeLocation finds the volume location from master topo if it is leader,
|
||||||
// or from master client if not leader
|
// or from master client if not leader
|
||||||
func (ms *MasterServer) findVolumeLocation(collection string, vid string) operation.LookupResult {
|
func (ms *MasterServer) findVolumeLocation(collection, vid string) operation.LookupResult {
|
||||||
var locations []operation.Location
|
var locations []operation.Location
|
||||||
var err error
|
var err error
|
||||||
if ms.Topo.IsLeader() {
|
if ms.Topo.IsLeader() {
|
||||||
|
|
|
@ -98,7 +98,7 @@ func writeDataNodeInfo(writer io.Writer, t *master_pb.DataNodeInfo) statistics {
|
||||||
}
|
}
|
||||||
func writeVolumeInformationMessage(writer io.Writer, t *master_pb.VolumeInformationMessage) statistics {
|
func writeVolumeInformationMessage(writer io.Writer, t *master_pb.VolumeInformationMessage) statistics {
|
||||||
fmt.Fprintf(writer, " volume %+v \n", t)
|
fmt.Fprintf(writer, " volume %+v \n", t)
|
||||||
return newStatiscis(t)
|
return newStatistics(t)
|
||||||
}
|
}
|
||||||
|
|
||||||
type statistics struct {
|
type statistics struct {
|
||||||
|
@ -108,7 +108,7 @@ type statistics struct {
|
||||||
DeletedBytes uint64
|
DeletedBytes uint64
|
||||||
}
|
}
|
||||||
|
|
||||||
func newStatiscis(t *master_pb.VolumeInformationMessage) statistics {
|
func newStatistics(t *master_pb.VolumeInformationMessage) statistics {
|
||||||
return statistics{
|
return statistics{
|
||||||
Size: t.Size,
|
Size: t.Size,
|
||||||
FileCount: t.FileCount,
|
FileCount: t.FileCount,
|
||||||
|
|
Loading…
Reference in a new issue